-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Uncomment Marker icons now that ImageListener API change has landed in stable #2443
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
398db9c
to
0c33c0d
Compare
0c33c0d
to
002732d
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks. Probably need rebase tho :)
@timsneath Are you planning on updating this? I just checked and it still applies, so we should get it rebased and landed. |
Oh wow -- yeah, I can reland this. |
Merged in the latest master, updated for NNBD, and removed the version bump since it's example-only (so doesn't really affect the published version). |
This pull request is not suitable for automatic merging in its current state.
|
Description
This change resolves issue flutter/flutter#33438.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?