-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[shared_preferences] add a no-op android folder to web/macos packages #2409
Conversation
packages/shared_preferences/shared_preferences_macos/android/gradle.properties
Outdated
Show resolved
Hide resolved
|
||
defaultConfig { | ||
minSdkVersion 16 | ||
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This should probably be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
android.useAndroidX=true | ||
android.enableJetifier=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should also probably be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
defaultConfig { | ||
minSdkVersion 16 | ||
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This should probably be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@mklim PTAL |
4bb3967
to
05b9702
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…flutter#2409) Adding an android/ folder as a temporary mitigation for: flutter/flutter#46898
…flutter#2409) Adding an android/ folder as a temporary mitigation for: flutter/flutter#46898
Description
Adding an android/ folder as a temporary mitigation for: flutter/flutter#46898