Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[shared_preferences] add a no-op android folder to web/macos packages #2409

Merged
merged 3 commits into from
Dec 12, 2019

Conversation

amirh
Copy link
Contributor

@amirh amirh commented Dec 12, 2019

Description

Adding an android/ folder as a temporary mitigation for: flutter/flutter#46898


defaultConfig {
minSdkVersion 16
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This should probably be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines 3 to 4
android.useAndroidX=true
android.enableJetifier=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should also probably be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


defaultConfig {
minSdkVersion 16
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This should probably be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@amirh
Copy link
Contributor Author

amirh commented Dec 12, 2019

@mklim PTAL

@amirh amirh force-pushed the shared_preferences_androids branch from 4bb3967 to 05b9702 Compare December 12, 2019 19:51
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amirh amirh merged commit 7b6f0c0 into flutter:master Dec 12, 2019
@amirh amirh deleted the shared_preferences_androids branch December 12, 2019 20:36
sanekyy pushed a commit to sanekyy/plugins that referenced this pull request Dec 21, 2019
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants