Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Commit

Permalink
fix the nnbd plugin test exclusion logic
Browse files Browse the repository at this point in the history
  • Loading branch information
amirh committed Dec 17, 2020
1 parent 05879a3 commit 16d759e
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 2 deletions.
16 changes: 16 additions & 0 deletions .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,16 @@ task:
- flutter channel $CHANNEL
- ./script/incremental_build.sh test
- name: analyze
env:
matrix:
CHANNEL: "master"
CHANNEL: "stable"
script: ./script/incremental_build.sh analyze
- name: build_all_plugins_apk
env:
matrix:
CHANNEL: "master"
CHANNEL: "stable"
script:
# TODO(jackson): Allow web plugins once supported on stable
# https://github.com/flutter/flutter/issues/42864
Expand Down Expand Up @@ -143,6 +151,10 @@ task:
- xcrun simctl create Flutter-iPhone com.apple.CoreSimulator.SimDeviceType.iPhone-X com.apple.CoreSimulator.SimRuntime.iOS-13-3 | xargs xcrun simctl boot
matrix:
- name: build_all_plugins_ipa
env:
matrix:
CHANNEL: "master"
CHANNEL: "stable"
script:
# TODO(jackson): Allow web plugins once supported on stable
# https://github.com/flutter/flutter/issues/42864
Expand Down Expand Up @@ -196,6 +208,10 @@ task:
activate_script: pub global activate flutter_plugin_tools
matrix:
- name: build_all_plugins_app
env:
matrix:
CHANNEL: "master"
CHANNEL: "stable"
script:
- flutter channel master
- ./script/build_all_plugins_app.sh macos
Expand Down
2 changes: 1 addition & 1 deletion script/build_all_plugins_app.sh
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ readonly EXCLUDED=$(IFS=, ; echo "${EXCLUDED_PLUGINS_LIST[*]}")

ALL_EXCLUDED=($EXCLUDED)
# Exclude nnbd plugins from stable.
if [[ "$CHANNEL" -eq "stable" ]]; then
if [ "$CHANNEL" == "stable" ]; then
ALL_EXCLUDED=("$EXCLUDED,$EXCLUDED_PLUGINS_FROM_STABLE")
fi

Expand Down
2 changes: 1 addition & 1 deletion script/incremental_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ fi
# Plugins that are excluded from this task.
ALL_EXCLUDED=("")
# Exclude nnbd plugins from stable.
if [[ "$CHANNEL" -eq "stable" ]]; then
if [ "$CHANNEL" == "stable" ]; then
ALL_EXCLUDED=($EXCLUDED_PLUGINS_FROM_STABLE)
echo "Excluding the following plugins: $ALL_EXCLUDED"
fi
Expand Down

0 comments on commit 16d759e

Please sign in to comment.