[vector_garphics] fix execution on the web with WebAssembly #7991
Conversation
The `dart.library.html` variable is not available with wasm Since the web version is (currently) a no-op, flip the condition to check for dart:io instead
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
| @@ -4,7 +4,7 @@ repository: https://github.com/flutter/packages/tree/main/packages/vector_graphi | |||
| issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+vector_graphics%22 | |||
| # See https://github.com/flutter/flutter/issues/157626 before publishing a new | |||
| # version. | |||
There was a problem hiding this comment.
This PR ignored the TODO here, so vector_graphics is now mis-aligned with the vector_graphics_* versions. @jonahwilliams We need a versioning plan here ASAP.
There was a problem hiding this comment.
I thought these weren't being auto published yet?
There was a problem hiding this comment.
I got confirmed so I flipped the bit and assumed the robots would "do the right thing" 🤷
There was a problem hiding this comment.
I thought these weren't being auto published yet?
I needed to publish an initial version so that the pub.dev metadata (issue link, source link, etc.) would be correct. That literally landed yesterday at the end of my workday; I didn't expect someone to create a PR, ignore the comment on the version saying not to publish a new version yet, get it approved, and land it, all before I started my next day and could do a follow-up PR to mark them as unpublished.
flutter/packages@7cc1caa...796afa3 2024-11-01 [email protected] [google_maps_flutter] Update Android for non-nullable generics (flutter/packages#7990) 2024-11-01 [email protected] [various] Minor cleanup in recently imported packages (flutter/packages#7995) 2024-11-01 [email protected] [go_router] Update example app to Kotlin 1.9.0 (flutter/packages#7997) 2024-10-31 [email protected] Manual roll Flutter from fe71cad to 0fe6153 (18 revisions) (flutter/packages#7989) 2024-10-31 [email protected] [vector_garphics] fix execution on the web with WebAssembly (flutter/packages#7991) 2024-10-31 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.9.0 to 1.9.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7986) 2024-10-31 [email protected] [flutter_svg] Initial import (flutter/packages#7944) 2024-10-31 [email protected] [vector_graphics] Initial import (flutter/packages#7941) 2024-10-30 [email protected] [ci] Ensure repo tool is autoformatted (flutter/packages#7963) 2024-10-30 [email protected] Updates path_parsing README.md with a note about Dan (flutter/packages#7949) 2024-10-30 [email protected] [tool] Support third_party for --current-package (flutter/packages#7967) 2024-10-30 [email protected] [tool] Fix third_party dependency overrides (flutter/packages#7966) 2024-10-30 [email protected] Applied Gradle Plugins Declaratively for `path_provider` (flutter/packages#7822) 2024-10-30 [email protected] [palette_generator] Remove unmanaged code snippet (flutter/packages#7962) 2024-10-30 [email protected] Roll Flutter from 42132e8 to fe71cad (12 revisions) (flutter/packages#7961) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The
dart.library.htmlvariable is not available with wasmSince the web version is (currently) a no-op, flip the condition to
check for dart:io instead