-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rfw] Upgrade missed example app #7545
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p: rfw
Remote Flutter Widgets
platform-android
p: extension_google_sign_in_as_googleapis_auth
labels
Aug 29, 2024
gmackall
changed the title
[rfw] Upgrade missed example app
[rfw, extension_google_sign_in_as_googleapis_auth] Upgrade missed example app
Aug 29, 2024
gmackall
force-pushed
the
whoops_missed_tfw
branch
from
September 3, 2024 18:02
616abae
to
a9e4ce3
Compare
gmackall
changed the title
[rfw, extension_google_sign_in_as_googleapis_auth] Upgrade missed example app
[rfw] Upgrade missed example app
Sep 3, 2024
stuartmorgan
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gmackall
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Sep 3, 2024
11 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 4, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 4, 2024
flutter/packages@848d7e9...e93995a 2024-09-04 [email protected] [google_maps_flutter_android] Convert `JointType` to an enum (flutter/packages#7558) 2024-09-04 [email protected] [flutter_adaptive_scaffold] Go router sample for AdaptiveScaffold (flutter/packages#7452) 2024-09-04 [email protected] [flutter_adaptive_scaffold] Fix breakpoint not being active in certain cases like foldables (flutter/packages#7549) 2024-09-03 [email protected] [google_sign_in_android] Downgrade Guava version from `33.3.0` to `32.0.1` (flutter/packages#7573) 2024-09-03 [email protected] [google_maps_flutter] Remove unused MapKit imports from iOS example apps (flutter/packages#7522) 2024-09-03 [email protected] [interactive_media_ads] Adds support for pausing and resuming Ad playback and skipping an Ad (flutter/packages#7285) 2024-09-03 [email protected] [rfw] Upgrade missed example app (flutter/packages#7545) 2024-09-03 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 1.4.0 to 1.4.1 in /packages/video_player/video_player_android/android (flutter/packages#7564) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
p: rfw
Remote Flutter Widgets
platform-android
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rfw
has multiple example apps - I missed this one in #7521.Also missed
extension_google_sign_in_as_googleapis_auth
- will need to upgrade that in a follow up PR (it has additional failures after the AGP upgrade, so it isn't a one line fix).Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.