Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve benchmarks with COOP/COEP headers in wasm mode. #7423

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

eyebrowsoffire
Copy link
Contributor

We need crossOriginIsolated for skwasm to work. Otherwise, this just falls back and benchmarks JS + canvaskit.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@yjbanov
Copy link
Contributor

yjbanov commented Aug 15, 2024

Can we test this by doing a simple dart:io HTTP fetch using a Dart test and checking for headers?

@eyebrowsoffire
Copy link
Contributor Author

Can we test this by doing a simple dart:io HTTP fetch using a Dart test and checking for headers?

I think I'm actually going to add some data to the benchmark payload that says some info about the environment, including whether it is wasm. Then I'll go ahead and confirm it matches that in the tests. I think that's a bit more comprehensive and gives me a better level of confidence than just inspecting the HTTP headers.

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 22, 2024
@auto-submit auto-submit bot merged commit d862279 into flutter:main Aug 22, 2024
76 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 23, 2024
flutter/packages@c5d03ee...d862279

2024-08-22 [email protected] Serve benchmarks with COOP/COEP headers in wasm mode. (flutter/packages#7423)
2024-08-21 [email protected] [google_maps_flutter_android] Convert `PlatformPolygon` and `PlatformPolyline` to Pigeon (flutter/packages#7406)
2024-08-21 [email protected] [pigeon] simplifies int handling across the codec, verifies ints in collections (flutter/packages#7392)
2024-08-21 [email protected] Roll Flutter (stable) from 80c2e84 to 5874a72 (9 revisions) (flutter/packages#7472)
2024-08-21 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/interactive_media_ads/android (flutter/packages#7384)
2024-08-21 [email protected] Roll Flutter from e7da16d to b8f89f7 (28 revisions) (flutter/packages#7471)
2024-08-21 [email protected] [interactive_media_ads] Adds a contribution doc (flutter/packages#7460)
2024-08-21 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#7373)
2024-08-21 [email protected] [script] Remove unnecessary breaks in default clauses of switch statements (flutter/packages#7469)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
flutter/packages@c5d03ee...d862279

2024-08-22 [email protected] Serve benchmarks with COOP/COEP headers in wasm mode. (flutter/packages#7423)
2024-08-21 [email protected] [google_maps_flutter_android] Convert `PlatformPolygon` and `PlatformPolyline` to Pigeon (flutter/packages#7406)
2024-08-21 [email protected] [pigeon] simplifies int handling across the codec, verifies ints in collections (flutter/packages#7392)
2024-08-21 [email protected] Roll Flutter (stable) from 80c2e84 to 5874a72 (9 revisions) (flutter/packages#7472)
2024-08-21 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/interactive_media_ads/android (flutter/packages#7384)
2024-08-21 [email protected] Roll Flutter from e7da16d to b8f89f7 (28 revisions) (flutter/packages#7471)
2024-08-21 [email protected] [interactive_media_ads] Adds a contribution doc (flutter/packages#7460)
2024-08-21 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#7373)
2024-08-21 [email protected] [script] Remove unnecessary breaks in default clauses of switch statements (flutter/packages#7469)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: web_benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants