[shared_preferences] Fixes get-all when suite name is used #7335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
reviewed
Aug 7, 2024
...d_preferences_foundation/Sources/shared_preferences_foundation/SharedPreferencesPlugin.swift
Show resolved
Hide resolved
fertrig
force-pushed
the
shared-prefs-fix
branch
from
9146aa8
to
c875838
Compare
In shared_preferences_foundation, fixes getting all preferences when suite name is used. Bug was reading only the standard user defaults. The fix uses suite name when available.
fertrig
force-pushed
the
shared-prefs-fix
branch
from
98f1f7e
to
f0e9d5f
Compare
tarrinneal
reviewed
Aug 8, 2024
| @@ -1,5 +1,5 @@ | |||
| ## NEXT | |||
There was a problem hiding this comment.
This will need to be changed to 2.5.1
|
@tarrinneal I think this PR is good now. |
|
I forgot during my last review that this will need testing in the integration tests (shared_preferences_foundation/example/integration_tests/shared_preferences_tests.dart), perhaps just running the entire test suite again with suite name. |
|
I added a couple of integration tests. Let me know what you think. Also, there may be a bug with the |
Did you want to test/fix that with this pr as well? (no pressure) |
|
No, when I test it I'll create a separate PR. |
tarrinneal
approved these changes
Aug 10, 2024
stuartmorgan
added
the
autosubmit
|
auto label is removed for flutter/packages/7335, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
stuartmorgan
added
the
autosubmit
|
That failure was the known infra flake, not related to the PR. |
|
auto label is removed for flutter/packages/7335, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 12, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 12, 2024
flutter/packages@f7b1256...d9a6de8 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/camera/camera_android/android (flutter/packages#7371) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/path_provider/path_provider_android/android (flutter/packages#7376) 2024-08-12 [email protected] [pigeon] removes restriction on number of custom types per file (flutter/packages#6840) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.0 to 2.0.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7370) 2024-08-12 [email protected] [shared_preferences] Fixes get-all when suite name is used (flutter/packages#7335) 2024-08-12 [email protected] [flutter_adaptive_scaffold] Add expanded and extra large breakpoints (flutter/packages#7300) 2024-08-12 [email protected] Manual roll Flutter from b12d861 to 9b84701 (8 revisions) (flutter/packages#7366) 2024-08-10 [email protected] Manual roll Flutter from 76107bd to b12d861 (14 revisions) (flutter/packages#7358) 2024-08-09 [email protected] [shared_preferences] fix cast error and mutable list error with `getStringList` (flutter/packages#7355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
flutter/packages@f7b1256...d9a6de8 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/camera/camera_android/android (flutter/packages#7371) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/path_provider/path_provider_android/android (flutter/packages#7376) 2024-08-12 [email protected] [pigeon] removes restriction on number of custom types per file (flutter/packages#6840) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.0 to 2.0.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7370) 2024-08-12 [email protected] [shared_preferences] Fixes get-all when suite name is used (flutter/packages#7335) 2024-08-12 [email protected] [flutter_adaptive_scaffold] Add expanded and extra large breakpoints (flutter/packages#7300) 2024-08-12 [email protected] Manual roll Flutter from b12d861 to 9b84701 (8 revisions) (flutter/packages#7366) 2024-08-10 [email protected] Manual roll Flutter from 76107bd to b12d861 (14 revisions) (flutter/packages#7358) 2024-08-09 [email protected] [shared_preferences] fix cast error and mutable list error with `getStringList` (flutter/packages#7355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@f7b1256...d9a6de8 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/camera/camera_android/android (flutter/packages#7371) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/path_provider/path_provider_android/android (flutter/packages#7376) 2024-08-12 [email protected] [pigeon] removes restriction on number of custom types per file (flutter/packages#6840) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.0 to 2.0.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7370) 2024-08-12 [email protected] [shared_preferences] Fixes get-all when suite name is used (flutter/packages#7335) 2024-08-12 [email protected] [flutter_adaptive_scaffold] Add expanded and extra large breakpoints (flutter/packages#7300) 2024-08-12 [email protected] Manual roll Flutter from b12d861 to 9b84701 (8 revisions) (flutter/packages#7366) 2024-08-10 [email protected] Manual roll Flutter from 76107bd to b12d861 (14 revisions) (flutter/packages#7358) 2024-08-09 [email protected] [shared_preferences] fix cast error and mutable list error with `getStringList` (flutter/packages#7355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In shared_preferences_foundation, fixes getting all preferences when suite name is used. Bug was reading only the standard user defaults. The fix uses suite name when available.
Issues fixed by this PR:
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].///).