-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shared_preferences] Fixes get-all when suite name is used #7335
Conversation
...d_preferences_foundation/Sources/shared_preferences_foundation/SharedPreferencesPlugin.swift
Show resolved
Hide resolved
9146aa8
to
c875838
Compare
In shared_preferences_foundation, fixes getting all preferences when suite name is used. Bug was reading only the standard user defaults. The fix uses suite name when available.
98f1f7e
to
f0e9d5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could run the format tool and update the changelog here those last two tests will pass. Thank you for putting this together.
@@ -1,5 +1,5 @@ | |||
## NEXT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be changed to 2.5.1
@tarrinneal I think this PR is good now. |
I forgot during my last review that this will need testing in the integration tests (shared_preferences_foundation/example/integration_tests/shared_preferences_tests.dart), perhaps just running the entire test suite again with suite name. |
I added a couple of integration tests. Let me know what you think. Also, there may be a bug with the |
Did you want to test/fix that with this pr as well? (no pressure) |
No, when I test it I'll create a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one (required) nit and the conflict updated and it's good to go. Thanks for finding and fixing this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
auto label is removed for flutter/packages/7335, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
That failure was the known infra flake, not related to the PR. |
auto label is removed for flutter/packages/7335, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/packages@f7b1256...d9a6de8 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/camera/camera_android/android (flutter/packages#7371) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/path_provider/path_provider_android/android (flutter/packages#7376) 2024-08-12 [email protected] [pigeon] removes restriction on number of custom types per file (flutter/packages#6840) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.0 to 2.0.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7370) 2024-08-12 [email protected] [shared_preferences] Fixes get-all when suite name is used (flutter/packages#7335) 2024-08-12 [email protected] [flutter_adaptive_scaffold] Add expanded and extra large breakpoints (flutter/packages#7300) 2024-08-12 [email protected] Manual roll Flutter from b12d861 to 9b84701 (8 revisions) (flutter/packages#7366) 2024-08-10 [email protected] Manual roll Flutter from 76107bd to b12d861 (14 revisions) (flutter/packages#7358) 2024-08-09 [email protected] [shared_preferences] fix cast error and mutable list error with `getStringList` (flutter/packages#7355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@f7b1256...d9a6de8 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/camera/camera_android/android (flutter/packages#7371) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/path_provider/path_provider_android/android (flutter/packages#7376) 2024-08-12 [email protected] [pigeon] removes restriction on number of custom types per file (flutter/packages#6840) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.0 to 2.0.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7370) 2024-08-12 [email protected] [shared_preferences] Fixes get-all when suite name is used (flutter/packages#7335) 2024-08-12 [email protected] [flutter_adaptive_scaffold] Add expanded and extra large breakpoints (flutter/packages#7300) 2024-08-12 [email protected] Manual roll Flutter from b12d861 to 9b84701 (8 revisions) (flutter/packages#7366) 2024-08-10 [email protected] Manual roll Flutter from 76107bd to b12d861 (14 revisions) (flutter/packages#7358) 2024-08-09 [email protected] [shared_preferences] fix cast error and mutable list error with `getStringList` (flutter/packages#7355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@f7b1256...d9a6de8 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/camera/camera_android/android (flutter/packages#7371) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/path_provider/path_provider_android/android (flutter/packages#7376) 2024-08-12 [email protected] [pigeon] removes restriction on number of custom types per file (flutter/packages#6840) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.0 to 2.0.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7370) 2024-08-12 [email protected] [shared_preferences] Fixes get-all when suite name is used (flutter/packages#7335) 2024-08-12 [email protected] [flutter_adaptive_scaffold] Add expanded and extra large breakpoints (flutter/packages#7300) 2024-08-12 [email protected] Manual roll Flutter from b12d861 to 9b84701 (8 revisions) (flutter/packages#7366) 2024-08-10 [email protected] Manual roll Flutter from 76107bd to b12d861 (14 revisions) (flutter/packages#7358) 2024-08-09 [email protected] [shared_preferences] fix cast error and mutable list error with `getStringList` (flutter/packages#7355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
In shared_preferences_foundation, fixes getting all preferences when suite name is used. Bug was reading only the standard user defaults. The fix uses suite name when available.
Issues fixed by this PR:
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.md
to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].///
).