Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Bump clang version to 18.1.8, was 15.0.0 #7271

Closed
wants to merge 4 commits into from

Conversation

Rexios80
Copy link
Member

@Rexios80 Rexios80 commented Aug 1, 2024

Newer versions of clang-format are generating different output than what is in the repository

Fixes flutter/flutter#152651

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Rexios80 Rexios80 requested a review from stuartmorgan August 1, 2024 13:29
@Rexios80 Rexios80 mentioned this pull request Aug 1, 2024
11 tasks
@Rexios80
Copy link
Member Author

Rexios80 commented Aug 1, 2024

Of course it wasn't that easy

@Rexios80
Copy link
Member Author

Rexios80 commented Aug 1, 2024

Welp that version doesn't seem to have the formatter changes

@Rexios80
Copy link
Member Author

Rexios80 commented Aug 1, 2024

Here are the possible paths I see from here:

  • Use latest clang not from Fuchsia (probably not viable)
  • Create a guide how to set up clang at the revision Fuchsia uses (overly complicated)
  • Pretend we didn't see anything (easy)

@Rexios80 Rexios80 marked this pull request as draft August 1, 2024 14:17
@Rexios80 Rexios80 closed this Aug 1, 2024
auto-submit bot pushed a commit that referenced this pull request Aug 2, 2024
This repo uses clang 15 to format files. Newer versions of clang format code differently. This PR adds a note to the tool README about this and adds sample instructions for how to install clang 15 on macOS. We might want to add instructions for other platforms.

Fixes flutter/flutter#152651

Additional context
- #7267
- #7271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[packages] Cleanup unformatted files
1 participant