-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gis_web] Allow package:web 1.0.0 #7203
Conversation
(First pass, see what CI thinks...) |
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
It's hard to test these, since they're a dependency only. CI seems happy, and I ran the tests as well. (Going to manually test google_sign_in_web real quick, which is not triggered in CI for this change)
|
@stuartmorgan I'm attempting to land a migration to I'm trying to get out of this knot, and retry the big merge later. (Let me know if you have a faster/better/safer idea to do this!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Let me know if you have a faster/better/safer idea to do this!)
This should be entirely safe; I see in CI logs that analyze
is indeed resolving to web
1.0.0, and downgrade analyze
is still resolving to 0.5.1
, so we have analysis coverage of the whole range.
Ranges are totally fine, and in some cases preferable to straight upgrades.
flutter/packages@1c319ac...19daf6f 2024-07-25 [email protected] Modernize the rest of the `index.html` files to support WASM compilation (flutter/packages#7192) 2024-07-25 [email protected] Add Linux support to Pigeon (flutter/packages#5100) 2024-07-24 [email protected] [gis_web] Allow package:web 1.0.0 (flutter/packages#7203) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@1c319ac...19daf6f 2024-07-25 [email protected] Modernize the rest of the `index.html` files to support WASM compilation (flutter/packages#7192) 2024-07-25 [email protected] Add Linux support to Pigeon (flutter/packages#5100) 2024-07-24 [email protected] [gis_web] Allow package:web 1.0.0 (flutter/packages#7203) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@1c319ac...19daf6f 2024-07-25 [email protected] Modernize the rest of the `index.html` files to support WASM compilation (flutter/packages#7192) 2024-07-25 [email protected] Add Linux support to Pigeon (flutter/packages#5100) 2024-07-24 [email protected] [gis_web] Allow package:web 1.0.0 (flutter/packages#7203) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Brackets the package:web dependency in gis_web to allow for
">=0.5.1 <2.0.0"
.Issues
This is needed so we can rebase and land:
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.