Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gis_web] Allow package:web 1.0.0 #7203

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Conversation

ditman
Copy link
Member

@ditman ditman commented Jul 23, 2024

Brackets the package:web dependency in gis_web to allow for ">=0.5.1 <2.0.0".

Issues

This is needed so we can rebase and land:

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman
Copy link
Member Author

ditman commented Jul 23, 2024

(First pass, see what CI thinks...)

@ditman ditman requested a review from yjbanov as a code owner July 23, 2024 22:13
@ditman ditman changed the title [gis_web] Update web to 1.0.0 [gis_web][benchmarks] Update web to 1.0.0 Jul 23, 2024
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@ditman ditman changed the title [gis_web][benchmarks] Update web to 1.0.0 [gis_web] Update web to 1.0.0 Jul 23, 2024
@ditman ditman changed the title [gis_web] Update web to 1.0.0 [gis_web] Allow package:web 1.0.0 Jul 23, 2024
@ditman
Copy link
Member Author

ditman commented Jul 23, 2024

It's hard to test these, since they're a dependency only. CI seems happy, and I ran the tests as well. (Going to manually test google_sign_in_web real quick, which is not triggered in CI for this change)

------------------------------------------------------------
Run overview:
  packages/google_sign_in/google_sign_in_web - ran

Ran for 1 package(s)


No issues found!

@ditman ditman requested a review from stuartmorgan July 23, 2024 23:48
@ditman
Copy link
Member Author

ditman commented Jul 23, 2024

@stuartmorgan I'm attempting to land a migration to web:^1.0.0. I think I can directly update most of the packages, but some dependencies of dependencies need to have a bracket in the web dependency.

I'm trying to get out of this knot, and retry the big merge later.

(Let me know if you have a faster/better/safer idea to do this!)

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Let me know if you have a faster/better/safer idea to do this!)

This should be entirely safe; I see in CI logs that analyze is indeed resolving to web 1.0.0, and downgrade analyze is still resolving to 0.5.1, so we have analysis coverage of the whole range.

Ranges are totally fine, and in some cases preferable to straight upgrades.

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 24, 2024
@auto-submit auto-submit bot merged commit 648c92d into flutter:main Jul 24, 2024
76 checks passed
@ditman ditman deleted the gis-to-web-1 branch July 24, 2024 19:50
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 25, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 25, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 25, 2024
flutter/packages@1c319ac...19daf6f

2024-07-25 [email protected] Modernize the rest of the `index.html` files to support WASM compilation (flutter/packages#7192)
2024-07-25 [email protected] Add Linux support to Pigeon (flutter/packages#5100)
2024-07-24 [email protected] [gis_web] Allow package:web 1.0.0 (flutter/packages#7203)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
flutter/packages@1c319ac...19daf6f

2024-07-25 [email protected] Modernize the rest of the `index.html` files to support WASM compilation (flutter/packages#7192)
2024-07-25 [email protected] Add Linux support to Pigeon (flutter/packages#5100)
2024-07-24 [email protected] [gis_web] Allow package:web 1.0.0 (flutter/packages#7203)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
flutter/packages@1c319ac...19daf6f

2024-07-25 [email protected] Modernize the rest of the `index.html` files to support WASM compilation (flutter/packages#7192)
2024-07-25 [email protected] Add Linux support to Pigeon (flutter/packages#5100)
2024-07-24 [email protected] [gis_web] Allow package:web 1.0.0 (flutter/packages#7203)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants