-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update web_benchmarks
package to properly support wasm.
#6970
Changes from 5 commits
15ade80
33b5612
c2f5ac7
47f381a
d2adb8c
5575336
461aba5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
## NEXT | ||
## 1.3.0 | ||
|
||
* Updates minimum supported SDK version to Flutter 3.16/Dart 3.2. | ||
* Support for running benchmarks with the wasm compilation target. | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needs a description of the breaking changes; see https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style |
||
## 1.2.2 | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,11 +7,15 @@ | |
/// This object holds metadata that is used to determine how the benchmark app | ||
/// should be built. | ||
class CompilationOptions { | ||
/// Creates a [CompilationOptions] object. | ||
const CompilationOptions({ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removing a constructor from a publicly exported class is a breaking change, and all of our packages follow semver. If you want to remove this, the package needs a major version bump. |
||
/// Creates a [CompilationOptions] object that compiles to JavaScript. | ||
const CompilationOptions.js({ | ||
this.renderer = WebRenderer.canvaskit, | ||
this.useWasm = false, | ||
}); | ||
}) : useWasm = false; | ||
|
||
/// Creates a [CompilationOptions] object that compiles to WebAssembly. | ||
const CompilationOptions.wasm() | ||
: useWasm = true, | ||
renderer = WebRenderer.skwasm; | ||
|
||
/// The renderer to use for the build. | ||
final WebRenderer renderer; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Adds support for [...]", per the repo CHANGELOG style guide.