[google_maps_flutter_platform_interface] Add improvements to BitmapDescriptor API #6687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
requested changes
May 8, 2024
packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/bitmap.dart
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/bitmap.dart
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_platform_interface/test/types/bitmap_test.dart
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_platform_interface/test/types/bitmap_test.dart
Outdated
Show resolved
Hide resolved
jokerttu
force-pushed
the
feature/google_maps_flutter_platform_interface_bitmapdescriptor_improvements
branch
from
04e97b8 to
c7a56e4
Compare
jokerttu
force-pushed
the
feature/google_maps_flutter_platform_interface_bitmapdescriptor_improvements
branch
3 times, most recently
from
8fa54ff to
2970bbd
Compare
jokerttu
force-pushed
the
feature/google_maps_flutter_platform_interface_bitmapdescriptor_improvements
branch
from
2970bbd to
a6a49a4
Compare
@stuartmorgan |
- Improves public api for width and height values of the MapBitmap - Also includes small fix to test naming.
jokerttu
force-pushed
the
feature/google_maps_flutter_platform_interface_bitmapdescriptor_improvements
branch
from
a6a49a4 to
8b51bc0
Compare
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 27, 2024
…BitmapDescriptor API (flutter/packages#6687)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 27, 2024
flutter/packages@7b423f5...b7bcb4b 2024-05-26 [email protected] Roll Flutter from cb26a01 to 6564471 (3 revisions) (flutter/packages#6796) 2024-05-26 [email protected] Update Flutter wiki links (flutter/packages#6789) 2024-05-25 [email protected] Roll Flutter from 8dd0831 to cb26a01 (12 revisions) (flutter/packages#6794) 2024-05-24 [email protected] [ci] Switch podspec check over to ARM (flutter/packages#6791) 2024-05-24 [email protected] [pointer_interceptor] Add Swift Package Manager support (flutter/packages#6790) 2024-05-24 [email protected] Roll Flutter from 8d955cd to 8dd0831 (22 revisions) (flutter/packages#6788) 2024-05-24 [email protected] [google_maps_flutter_platform_interface] Add improvements to BitmapDescriptor API (flutter/packages#6687) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced May 29, 2024
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
flutter/packages@7b423f5...b7bcb4b 2024-05-26 [email protected] Roll Flutter from cb26a01 to 6564471 (3 revisions) (flutter/packages#6796) 2024-05-26 [email protected] Update Flutter wiki links (flutter/packages#6789) 2024-05-25 [email protected] Roll Flutter from 8dd0831 to cb26a01 (12 revisions) (flutter/packages#6794) 2024-05-24 [email protected] [ci] Switch podspec check over to ARM (flutter/packages#6791) 2024-05-24 [email protected] [pointer_interceptor] Add Swift Package Manager support (flutter/packages#6790) 2024-05-24 [email protected] Roll Flutter from 8d955cd to 8dd0831 (22 revisions) (flutter/packages#6788) 2024-05-24 [email protected] [google_maps_flutter_platform_interface] Add improvements to BitmapDescriptor API (flutter/packages#6687) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
#6826) Platform implementations portion of : #4055 Adds platform handling for new BitmapDescriptor classes `AssetMapBitmap` and `BytesMapBitmap` introduced in #6687 Containing only changes to packages * `google_maps_flutter_android` * `google_maps_flutter_ios` * `google_maps_flutter_web` Follow up PR will hold the app-facing plugin implementations. Linked issue: flutter/flutter#34657
jokerttu
deleted the
feature/google_maps_flutter_platform_interface_bitmapdescriptor_improvements
branch
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…scriptor API (flutter#6687) This PR adds improvements to BitmapDescriptor API for google_maps_flutter_platform_interface * Adds better support for marker size and scaling behaviour with `AssetMapBitmap` and `BytesMapBitmap`. * Deprecates `BitmapDescriptor.fromAssetImage` in favor of `BitmapDescriptor.asset` and `AssetMapBitmap.create`. * Deprecates `BitmapDescriptor.fromBytes` in favor of `BitmapDescriptor.bytes` and `BytesMapBitmap` This is prequel PR for: flutter#4055 Containing only changes to `google_maps_flutter_platform_interface` package. Follow up PR:s will hold the platform and app-facing plugin implementations. Linked issue: flutter/flutter#34657
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
flutter#6826) Platform implementations portion of : flutter#4055 Adds platform handling for new BitmapDescriptor classes `AssetMapBitmap` and `BytesMapBitmap` introduced in flutter#6687 Containing only changes to packages * `google_maps_flutter_android` * `google_maps_flutter_ios` * `google_maps_flutter_web` Follow up PR will hold the app-facing plugin implementations. Linked issue: flutter/flutter#34657
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds improvements to BitmapDescriptor API for google_maps_flutter_platform_interface
AssetMapBitmapandBytesMapBitmap.BitmapDescriptor.fromAssetImagein favor ofBitmapDescriptor.assetandAssetMapBitmap.create.BitmapDescriptor.fromBytesin favor ofBitmapDescriptor.bytesandBytesMapBitmapThis is prequel PR for: #4055
Containing only changes to
google_maps_flutter_platform_interfacepackage.Follow up PR:s will hold the platform and app-facing plugin implementations.
Linked issue: flutter/flutter#34657
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.