-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[camerax] Add empty implementation for prepareForVideoRecording
not used on Android
#6676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbaker
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should still have a test to ensure we dont regress and make this not callable.
gmackall
approved these changes
May 6, 2024
camsim99
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
May 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 7, 2024
…ing` not used on Android (flutter/packages#6676)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 7, 2024
flutter/packages@2dfe645...5ccddfc 2024-05-06 [email protected] [shared_preferences_foundation] Adds Swift Package Manager compatibility (flutter/packages#6640) 2024-05-06 [email protected] [file_selector] Add support for SPM (flutter/packages#6672) 2024-05-06 [email protected] [camerax] Add empty implementation for `prepareForVideoRecording` not used on Android (flutter/packages#6676) 2024-05-06 [email protected] [ci] Reduce the number of tasks in recipe CQ (flutter/packages#6673) 2024-05-06 [email protected] Roll Flutter from f1037a0 to 04424e1 (25 revisions) (flutter/packages#6674) 2024-05-06 [email protected] [camerax] Prevent using unsupported concurrent camera use cases (flutter/packages#6608) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
… used on Android (flutter#6676) Adds empty implementation for the camera plugin method `prepareForVideoRecording` that is not used on Android. Prequel to flutter#6629
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
… used on Android (flutter#6676) Adds empty implementation for the camera plugin method `prepareForVideoRecording` that is not used on Android. Prequel to flutter#6629
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds empty implementation for the camera plugin method
prepareForVideoRecording
that is not used on Android.Prequel to #6629
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).