[google_sign_in_web] README.md typo #6642
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks for the contribution! You’ve checked boxes in the PR checklist above that are not reflected in this PR, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when the checklist reflects the state of the PR as posted please feel free to mark it as ready for review. |
There was a problem hiding this comment.
Please @Jerinji2016, make sure you update the pubspec.yaml and CHANGELOG so this README update gets published to pub. Thanks for the fix!
|
@ditman |
| @@ -1,3 +1,6 @@ | |||
| ## 0.12.4+1 | |||
| * Fixed README.md typo | |||
There was a problem hiding this comment.
Please follow the changeliog style guide linked from the PR checklist.
There was a problem hiding this comment.
I think I need to change version to NEXT.
Should I revert the version change in pubspec too?
There was a problem hiding this comment.
I recommend reading the FAQ section of the linked documentation about READMEs and version updates. Also, you haven't addressed the CHANGELOG message style issues raised in the comment you are replying to.
Please read the documentation linked from the PR checklist; the reason we have the checklist is to provide guidance and links to relevant documentation.
There was a problem hiding this comment.
This still doesn't use the correct verb form, and still doesn't have a period, so none of the style issues have been resolved.
| @@ -1,3 +1,6 @@ | |||
| ## 0.12.4+1 | |||
| * Fixed README.md typo | |||
There was a problem hiding this comment.
I recommend reading the FAQ section of the linked documentation about READMEs and version updates. Also, you haven't addressed the CHANGELOG message style issues raised in the comment you are replying to.
Please read the documentation linked from the PR checklist; the reason we have the checklist is to provide guidance and links to relevant documentation.
There was a problem hiding this comment.
This PR is still not following a lot of our process. The process is here for a reason; please don't skip it.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
This is still placeholder text.
- The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences]
This box is checked despite this step not having been done.
- I linked to at least one issue that this PR fixes in the description above.
Why is this box checked?
- I updated
CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.
This style guide is still not being followed in the PR, as noted below.
| @@ -1,3 +1,6 @@ | |||
| ## 0.12.4+1 | |||
| * Fixed README.md typo | |||
There was a problem hiding this comment.
This still doesn't use the correct verb form, and still doesn't have a period, so none of the style issues have been resolved.
|
@stuartmorgan |
flutter/packages@711b4ac...03f5f6d 2024-06-24 [email protected] [interactive_media_ads] Fix README badge image URL (flutter/packages#6979) 2024-06-24 [email protected] [multicast_dns] Optimized Socket Binding: Always bind to 0.0.0.0 for simplicity and efficiency - #79772 (flutter/packages#6700) 2024-06-24 [email protected] [flutter_adaptive_scaffold] Allows for the animation duration to be adjusted using SlotLayout.from() (flutter/packages#6510) 2024-06-22 [email protected] [in_app_purchase_storekit] Remove OCMock (flutter/packages#6862) 2024-06-22 [email protected] [google_maps_flutter] Add iOS SDK 9.x support (flutter/packages#6902) 2024-06-21 [email protected] [google_maps_flutter] Partial Android host API Pigeon conversion (flutter/packages#6967) 2024-06-21 [email protected] Revert "Migrate `camera/android` from `SurfaceTexture`->`SurfaceProducer`." (flutter/packages#6964) 2024-06-21 [email protected] [quick_actions] Update to Pigeon 20 (flutter/packages#6961) 2024-06-20 [email protected] [google_maps_flutter] Move Android inspector to Pigeon (flutter/packages#6958) 2024-06-20 [email protected] Manual roll Flutter from ccf3abe to 6c06abb (21 revisions) (flutter/packages#6954) 2024-06-20 [email protected] [many] More v1 embedding deletion that was missed in flutter/packages#6494 (flutter/packages#6923) 2024-06-20 [email protected] [google_maps_flutter] deprecate old BitmapDescriptor methods (flutter/packages#6905) 2024-06-18 [email protected] [pigeon] Fully-qualify types in Equatable extension test (flutter/packages#6946) 2024-06-18 [email protected] [flutter_markdown] fixes null check operator used on null value if onSelectionChanged is� (flutter/packages#6883) 2024-06-17 [email protected] Roll Flutter from 5187cab to ccf3abe (6 revisions) (flutter/packages#6940) 2024-06-17 [email protected] [google_sign_in_web] README.md typo (flutter/packages#6642) 2024-06-17 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.google.guava:guava from 32.0.1-android to 33.2.1-android and CameraX version to 1.3.4 in /packages/camera/camera_android_camerax/android (flutter/packages#6847) 2024-06-17 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.guava:guava from 32.0.1-android to 33.2.1-android in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#6846) 2024-06-17 49699333+dependabot[bot]@users.noreply.github.com [quick_actions]: Bump com.android.tools.build:gradle from 7.2.1 to 8.4.1 in /packages/quick_actions/quick_actions_android/android (flutter/packages#6799) 2024-06-17 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/path_provider/path_provider_android/android (flutter/packages#6773) 2024-06-17 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/camera/camera_android/android (flutter/packages#6766) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR has changes to a typo in the README.md in google_sign_in_web
List of Issues fixed:
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.