[go_router_builder] Add test for onExit
#6614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
The tests are failing because of #6623 |
…dd-tests-for-on-exit # Conflicts: # packages/go_router_builder/CHANGELOG.md
auto-submit bot
pushed a commit
that referenced
this pull request
May 14, 2024
…o the `onExit` (#6623) While working on #6614, I notice some issues with the state that is given to the `onExit` (see the run https://github.com/flutter/packages/pull/6614/checks?check_run_id=24284539541) This PR uses the correct configuration to build the state and pass it to the `onExit`
…dd-tests-for-on-exit # Conflicts: # packages/go_router_builder/CHANGELOG.md
ValentinVignal
force-pushed
the
go-router-builder/Add-tests-for-on-exit
branch
from
39d7939 to
0f8be0e
Compare
…dd-tests-for-on-exit # Conflicts: # packages/go_router_builder/CHANGELOG.md
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 17, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 17, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 17, 2024
flutter/packages@87a02e3...ae4dd32 2024-05-17 [email protected] Roll Flutter from 0d22d91 to 00425ef (14 revisions) (flutter/packages#6753) 2024-05-16 [email protected] [go_router_builder] Add test for `onExit` (flutter/packages#6614) 2024-05-16 [email protected] [camera_android_camerax] update to latest stable camerax 1.3.3 (flutter/packages#6737) 2024-05-16 [email protected] [camera_avfoundation] Revert camera example PRODUCT_BUNDLE_IDENTIFIER (flutter/packages#6735) 2024-05-16 [email protected] [file_selector_ios, image_picker_ios] Remove Swift Package Support (flutter/packages#6740) 2024-05-16 [email protected] [two_dimensional_scrollables] TreeView (flutter/packages#6592) 2024-05-16 [email protected] Roll Flutter from 39651e8 to 0d22d91 (23 revisions) (flutter/packages#6748) 2024-05-16 [email protected] [pigeon][swift] Removes FlutterError in favor of PigeonError (flutter/packages#6611) 2024-05-16 [email protected] [webview_flutter] Skip "Video playback policy" drive tests (flutter/packages#6747) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
…o the `onExit` (flutter#6623) While working on flutter#6614, I notice some issues with the state that is given to the `onExit` (see the run https://github.com/flutter/packages/pull/6614/checks?check_run_id=24284539541) This PR uses the correct configuration to build the state and pass it to the `onExit`
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…o the `onExit` (flutter#6623) While working on flutter#6614, I notice some issues with the state that is given to the `onExit` (see the run https://github.com/flutter/packages/pull/6614/checks?check_run_id=24284539541) This PR uses the correct configuration to build the state and pass it to the `onExit`
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #6495
Fixes flutter/flutter#137394
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.