Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Add more dev dependency checks, and fix errors #6563

Merged
merged 1 commit into from
Apr 18, 2024
Merged

[ci] Add more dev dependency checks, and fix errors #6563

merged 1 commit into from
Apr 18, 2024

Conversation

stuartmorgan
Copy link
Contributor

  • Adds build_runner, mockito, and pigeon to the list of dependencies that we expect to only be in dev_dependencies.
  • Fixes the error message for violations; I had missed in initial review that the errorr message was the same as the one for non-repo-local depndencies, making it misleading about what the problem was and how to fix it. (Also fixed the indentation, which had always been wrong.)
  • Fixes camera_avfoundation, which had a violation introduced in my recent PR to start the Pigeon conversion.

See flutter/flutter#117905

Pre-launch Checklist

@stuartmorgan
[ci] Add more dev dependency checks, and fix errors
0625cf7 
- Adds `build_runner`, `mockito`, and `pigeon` to the list of
  dependencies that we expect to only be in dev_dependencies.
- Fixes the error message for violations; I had missed in initial review
  that the errorr message was the same as the one for non-repo-local
  depndencies, making it misleading about what the problem was and how
  to fix it. (Also fixed the indentation, which had always been wrong.)
- Fixes `camera_avfoundation`, which had a violation introduced in my
  recent PR to start the Pigeon conversion.

See flutter/flutter#117905
stuartmorgan
stuartmorgan commented Apr 18, 2024
View reviewed changes
script/tool/test/pubspec_check_command_test.dart
'test',
];
for (final String dependency in packages) {
test('fails when $dependency is used in non dev dependency',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I switched the structure to a loop-constructed test set where each test only checks one package, because it's easier to ensure that everything is actually being covered (e.g., that we don't add a package to the list of dependencies, but forget to add it to the error message, so that it looks like it's being tested but actually isn't).

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2024
@stuartmorgan stuartmorgan mentioned this pull request Apr 18, 2024
Merged
11 tasks
@auto-submit auto-submit bot merged commit bb82cb7 into flutter:main Apr 18, 2024
78 checks passed
@stuartmorgan stuartmorgan deleted the dev-dependency-fixes branch April 19, 2024 02:06
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 19, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 19, 2024
@engine-flutter-autoroll
bb82cb7 [ci] Add more dev dependency checks, and fix errors (flutter/…
1ac9e8a 
…packages#6563)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 19, 2024
@engine-flutter-autoroll
Roll Packages from 0e3809d to 88a3a56 (4 revisions) (#147059)
66cdf11 
flutter/packages@0e3809d...88a3a56

2024-04-19 [email protected] [camera] Convert iOS Obj-C->Dart calls to Pigeon (flutter/packages#6568)
2024-04-19 [email protected] [flutter_markdown] Ensure customize nested bullet list style. (flutter/packages#6384)
2024-04-18 [email protected] [ci] Add more dev dependency checks, and fix errors (flutter/packages#6563)
2024-04-18 [email protected] Roll Flutter from 3882afb to fb110b9 (56 revisions) (flutter/packages#6565)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
@engine-flutter-autoroll @gilnobrega
Roll Packages from 0e3809d to 88a3a56 (4 revisions) (flutter#147059)
92e48f6 
flutter/packages@0e3809d...88a3a56

2024-04-19 [email protected] [camera] Convert iOS Obj-C->Dart calls to Pigeon (flutter/packages#6568)
2024-04-19 [email protected] [flutter_markdown] Ensure customize nested bullet list style. (flutter/packages#6384)
2024-04-18 [email protected] [ci] Add more dev dependency checks, and fix errors (flutter/packages#6563)
2024-04-18 [email protected] Roll Flutter from 3882afb to fb110b9 (56 revisions) (flutter/packages#6565)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@stuartmorgan @TecHaxter
[ci] Add more dev dependency checks, and fix errors (flutter#6563)
bad79d1 
- Adds `build_runner`, `mockito`, and `pigeon` to the list of dependencies that we expect to only be in dev_dependencies.
- Fixes the error message for violations; I had missed in initial review that the errorr message was the same as the one for non-repo-local depndencies, making it misleading about what the problem was and how to fix it. (Also fixed the indentation, which had always been wrong.)
- Fixes `camera_avfoundation`, which had a violation introduced in my recent PR to start the Pigeon conversion.

See flutter/flutter#117905
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@stuartmorgan @arc-yong
[ci] Add more dev dependency checks, and fix errors (flutter#6563)
cb1c54a 
- Adds `build_runner`, `mockito`, and `pigeon` to the list of dependencies that we expect to only be in dev_dependencies.
- Fixes the error message for violations; I had missed in initial review that the errorr message was the same as the one for non-repo-local depndencies, making it misleading about what the problem was and how to fix it. (Also fixed the indentation, which had always been wrong.)
- Fixes `camera_avfoundation`, which had a violation introduced in my recent PR to start the Pigeon conversion.

See flutter/flutter#117905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellohuanlin hellohuanlin hellohuanlin approved these changes

@reidbaker reidbaker reidbaker approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

@tarrinneal tarrinneal Awaiting requested review from tarrinneal

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera platform-ios platform-macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartmorgan @reidbaker @hellohuanlin