-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add limit to image_picker_platform_interface #6434
Merged
auto-submit
merged 4 commits into
flutter:main
from
pdenert:add-limit-to-image-picker-platform-interface
Apr 7, 2024
Merged
Add limit to image_picker_platform_interface #6434
auto-submit
merged 4 commits into
flutter:main
from
pdenert:add-limit-to-image-picker-platform-interface
Apr 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
11 tasks
pdenert
force-pushed
the
add-limit-to-image-picker-platform-interface
branch
from
March 29, 2024 14:11
db772a1
to
c00d8de
Compare
tarrinneal
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stuartmorgan for 2nd
stuartmorgan
requested changes
Apr 5, 2024
packages/image_picker/image_picker_platform_interface/lib/src/types/media_options.dart
Show resolved
Hide resolved
...cker/image_picker_platform_interface/lib/src/method_channel/method_channel_image_picker.dart
Outdated
Show resolved
Hide resolved
packages/image_picker/image_picker_platform_interface/lib/src/types/media_options.dart
Show resolved
Hide resolved
packages/image_picker/image_picker_platform_interface/lib/src/types/media_options.dart
Outdated
Show resolved
Hide resolved
...s/image_picker/image_picker_platform_interface/lib/src/types/multi_image_picker_options.dart
Show resolved
Hide resolved
stuartmorgan
approved these changes
Apr 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stuartmorgan
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Apr 7, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 8, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 8, 2024
flutter/packages@764d997...6b4d8b6 2024-04-08 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.9 to 3.24.10 (flutter/packages#6480) 2024-04-07 [email protected] Add limit to image_picker_platform_interface (flutter/packages#6434) 2024-04-07 [email protected] Roll Flutter from 477ebd8 to 98d23f7 (16 revisions) (flutter/packages#6478) 2024-04-05 [email protected] Roll Flutter from ac2ca93 to 477ebd8 (32 revisions) (flutter/packages#6470) 2024-04-05 [email protected] [camera] Camera with MediaSettings: platform implementations (federated) (flutter/packages#5223) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
flutter/packages@764d997...6b4d8b6 2024-04-08 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.9 to 3.24.10 (flutter/packages#6480) 2024-04-07 [email protected] Add limit to image_picker_platform_interface (flutter/packages#6434) 2024-04-07 [email protected] Roll Flutter from 477ebd8 to 98d23f7 (16 revisions) (flutter/packages#6478) 2024-04-05 [email protected] Roll Flutter from ac2ca93 to 477ebd8 (32 revisions) (flutter/packages#6470) 2024-04-05 [email protected] [camera] Camera with MediaSettings: platform implementations (federated) (flutter/packages#5223) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
Adds limit parameter to `MediaOptions` and `MultiImagePickerOptions`. The `limit` argument defines how many images or media files can be select. Only platform interface package changes taken from: flutter#6201 Fixes: [flutter/flutter#85772](flutter/flutter#85772)
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
Adds limit parameter to `MediaOptions` and `MultiImagePickerOptions`. The `limit` argument defines how many images or media files can be select. Only platform interface package changes taken from: flutter#6201 Fixes: [flutter/flutter#85772](flutter/flutter#85772)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds limit parameter to
MediaOptions
andMultiImagePickerOptions
. Thelimit
argument defines how many images or media files can be select.Only platform interface package changes taken from: #6201
Fixes: flutter/flutter#85772
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.