Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limit to image_picker_platform_interface #6434

Merged

Conversation

pdenert
Copy link
Contributor

@pdenert pdenert commented Mar 28, 2024

Adds limit parameter to MediaOptions and MultiImagePickerOptions. The limit argument defines how many images or media files can be select.

Only platform interface package changes taken from: #6201

Fixes: flutter/flutter#85772

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@pdenert pdenert force-pushed the add-limit-to-image-picker-platform-interface branch from db772a1 to c00d8de Compare March 29, 2024 14:11
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartmorgan for 2nd

@tarrinneal tarrinneal requested a review from stuartmorgan April 1, 2024 21:12
@pdenert pdenert requested a review from stuartmorgan April 5, 2024 22:22
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2024
@auto-submit auto-submit bot merged commit 3a21cfa into flutter:main Apr 7, 2024
78 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 8, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 8, 2024
flutter/packages@764d997...6b4d8b6

2024-04-08 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.9 to 3.24.10 (flutter/packages#6480)
2024-04-07 [email protected] Add limit to image_picker_platform_interface (flutter/packages#6434)
2024-04-07 [email protected] Roll Flutter from 477ebd8 to 98d23f7 (16 revisions) (flutter/packages#6478)
2024-04-05 [email protected] Roll Flutter from ac2ca93 to 477ebd8 (32 revisions) (flutter/packages#6470)
2024-04-05 [email protected] [camera] Camera with MediaSettings: platform implementations (federated) (flutter/packages#5223)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
flutter/packages@764d997...6b4d8b6

2024-04-08 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.9 to 3.24.10 (flutter/packages#6480)
2024-04-07 [email protected] Add limit to image_picker_platform_interface (flutter/packages#6434)
2024-04-07 [email protected] Roll Flutter from 477ebd8 to 98d23f7 (16 revisions) (flutter/packages#6478)
2024-04-05 [email protected] Roll Flutter from ac2ca93 to 477ebd8 (32 revisions) (flutter/packages#6470)
2024-04-05 [email protected] [camera] Camera with MediaSettings: platform implementations (federated) (flutter/packages#5223)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
Adds limit parameter to `MediaOptions` and `MultiImagePickerOptions`. The `limit` argument defines how many images or media files can be select.

Only platform interface package changes taken from: flutter#6201

Fixes: [flutter/flutter#85772](flutter/flutter#85772)
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
Adds limit parameter to `MediaOptions` and `MultiImagePickerOptions`. The `limit` argument defines how many images or media files can be select.

Only platform interface package changes taken from: flutter#6201

Fixes: [flutter/flutter#85772](flutter/flutter#85772)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: image_picker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

image_picker add picture limit to getMultiImage
3 participants