-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[google_sign_in_ios] Pins GoogleSignIn to 7.0.0 in podspec. #6430
[google_sign_in_ios] Pins GoogleSignIn to 7.0.0 in podspec. #6430
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to reopen the tree.
A proper fix for this issue is coming here: |
flutter/packages@924c7e6...51faaa1 2024-03-29 [email protected] [shared_preferences] Update mockito to the new version available 5.2.0 (flutter/packages#6332) 2024-03-29 [email protected] Manual roll Flutter (stable) from 68bfaea to 300451a (2 revisions) (flutter/packages#6433) 2024-03-28 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.exifinterface:exifinterface from 1.3.6 to 1.3.7 in /packages/image_picker/image_picker_android/android (flutter/packages#5705) 2024-03-28 [email protected] Manual roll Flutter from dbdcead to 89ea492 (54 revisions) (flutter/packages#6431) 2024-03-28 [email protected] [ci] Adds sleep 60s to release action. (flutter/packages#6405) 2024-03-28 [email protected] [go_router]: fix GoRouter.optionURLReflectsImperativeAPIs flag works with new imperative APIs (flutter/packages#6236) 2024-03-28 [email protected] [interactive_media_ads] Reland "Creates and adds the interactive_media_ads plugin #6060" (flutter/packages#6425) 2024-03-28 [email protected] [google_sign_in_ios] Pins GoogleSignIn to 7.0.0 in podspec. (flutter/packages#6430) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…6430) This PR temporarily pins the GoogleSignIn iOS SDK to version 7.0.0 in the darwin podspec configuration. This'll enable our CI to keep going, until a more proper fix to `google_sign_in_ios` lands, with an update to the latest [7.1 version](https://github.com/google/GoogleSignIn-iOS/releases). See: * flutter/flutter#145866 For more information about the current CI failures. ## Testing This PR should help with the tests that are currently broken in CI.
This PR temporarily pins the GoogleSignIn iOS SDK to version 7.0.0 in the darwin podspec configuration.
This'll enable our CI to keep going, until a more proper fix to
google_sign_in_ios
lands, with an update to the latest 7.1 version. See:For more information about the current CI failures.
Testing
This PR should help with the tests that are currently broken in CI.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.