-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[camerax] Update README to encourage users to opt in #6352
Changes from 2 commits
61f143e
4297c92
93f5933
86fd12e
36eeab3
b6a3ec9
cb576f9
1041abe
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,11 +2,12 @@ | |
|
||
An Android implementation of [`camera`][1] that uses the [CameraX library][2]. | ||
|
||
*Note*: This package is under development, so please note the | ||
[missing features and limitations](#missing-features-and-limitations), but | ||
otherwise feel free to try out the current implementation and provide any | ||
feedback by filing issues under [`flutter/flutter`][5] with `[camerax]` in | ||
the title, which will be actively triaged. | ||
*Note*: This implementation will eventually become the default implementation | ||
of `camera` on Android, so we strongly encourage you to opt into using it | ||
by using [the instructions](#usage) below. If any of [the limitations](#limitations) | ||
prevent you from using `camera_android_camerax` or if you run into any problems, | ||
please report these issues under [`flutter/flutter`][5] with `[camerax]` in | ||
the title. | ||
|
||
## Usage | ||
|
||
|
@@ -19,21 +20,17 @@ dependency in addition to `camera`: | |
dependencies: | ||
# ...along with your other dependencies | ||
camera: ^0.10.4 | ||
camera_android_camerax: ^0.5.0 | ||
camera_android_camerax: ^0.6.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will land after #6176 which will bump the plugin to version 0.6.0 as it has reached feature parity with camera_android. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Alternately, we could replace this whole section with something like "To use this plugin instead of |
||
``` | ||
|
||
## Missing features and limitations | ||
## Limitations | ||
|
||
### 240p resolution configuration for video recording | ||
|
||
240p resolution configuration for video recording is unsupported by CameraX, | ||
and thus, the plugin will fall back to 480p if configured with a | ||
`ResolutionPreset`. | ||
|
||
### Focus mode configuration \[[Issue #120467][120467]\] | ||
|
||
`setFocusMode` is unimplemented. | ||
|
||
### Setting maximum duration and stream options for video capture | ||
|
||
Calling `startVideoCapturing` with `VideoCaptureOptions` configured with | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit: should we be more prescriptive of when we estimate this becomes the default? eventually makes it still seem like it is far off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed this to "by May" to give us until I/O (though we should try making the breaking change well before then, at least a couple of weeks I'd say). LMK what you think!