-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README of package:process
#5475
Update README of package:process
#5475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires a version change, per our contributing docs. (I would suggest not deleting the checklist from the PR description in the future, as it covers required steps like that one.)
fixed the mistake - my bad, sorry |
packages/process/CHANGELOG.md
Outdated
|
||
* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0. | ||
* Remove mention of the removed record/replay feature from README. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removes
Per the style guide that was linked from the checklist.
Also, nit: we generally put the thing that was worth publishing for first, rather than last.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry again, I missed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was copied instead of moved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You deleted the new, corrected one (which addressed my original comment) instead of the old one.
packages/process/CHANGELOG.md
Outdated
|
||
* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0. | ||
* Remove mention of the removed record/replay feature from README. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was copied instead of moved.
@bartekpacia Are you still planning on updating this per the comments above? |
@stuartmorgan yes, I just pushed the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
flutter/packages@21b5abb...cbe8100 2024-01-25 [email protected] Update README of `package:process` (flutter/packages#5475) 2024-01-25 [email protected] Roll Flutter from 19b06f4 to a8efa77 (38 revisions) (flutter/packages#5969) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR fixes flutter/flutter#136221. BTW it's a great package! I use it extensively in [patrol_cli] and love it.
This PR fixes flutter/flutter#136221.
BTW it's a great package! I use it extensively in patrol_cli and love it.