Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README of package:process #5475

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Update README of package:process #5475

merged 1 commit into from
Jan 25, 2024

Conversation

bartekpacia
Copy link
Member

This PR fixes flutter/flutter#136221.

BTW it's a great package! I use it extensively in patrol_cli and love it.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires a version change, per our contributing docs. (I would suggest not deleting the checklist from the PR description in the future, as it covers required steps like that one.)

@bartekpacia
Copy link
Member Author

fixed the mistake - my bad, sorry


* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0.
* Remove mention of the removed record/replay feature from README.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes

Per the style guide that was linked from the checklist.

Also, nit: we generally put the thing that was worth publishing for first, rather than last.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry again, I missed it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was copied instead of moved.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏻

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You deleted the new, corrected one (which addressed my original comment) instead of the old one.


* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0.
* Remove mention of the removed record/replay feature from README.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was copied instead of moved.

@stuartmorgan
Copy link
Contributor

@bartekpacia Are you still planning on updating this per the comments above?

@bartekpacia
Copy link
Member Author

bartekpacia commented Jan 24, 2024

@stuartmorgan yes, I just pushed the changes.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartekpacia bartekpacia added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 25, 2024
@auto-submit auto-submit bot merged commit cbe8100 into flutter:main Jan 25, 2024
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 26, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 26, 2024
flutter/packages@21b5abb...cbe8100

2024-01-25 [email protected] Update README of `package:process` (flutter/packages#5475)
2024-01-25 [email protected] Roll Flutter from 19b06f4 to a8efa77 (38 revisions) (flutter/packages#5969)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
This PR fixes flutter/flutter#136221.

BTW it's a great package! I use it extensively in [patrol_cli] and love it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[process] Remove reference to record/replay in README
2 participants