Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[google_maps_flutter_web] Migrate to package:web #5254
[google_maps_flutter_web] Migrate to package:web #5254
Changes from all commits
8800cc7
0c9fc45
8960e3d
b420f32
a0637f1
636e71f
639fe97
c22678e
147e570
5ff2982
c4581dd
0fb3d67
9898737
18564d2
aa9533a
1667de9
c43f31e
a14981c
32d66fa
788d35a
1040103
edc00a8
cd2b0e8
861f294
bb8810f
e578d86
638a466
75db30d
2c086d2
fb7f53a
aee9770
9f2716e
cb9c665
aa46171
0523daa
e2df4b1
e358399
736aec1
8b4d7bb
d8adca1
52baeca
1951a6a
6583739
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I accidentally ran the example app once directly (using
flutter run -d chrome
) and it did throw an error about a missing Directionality widgetThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, the skeleton app is only used to have a Flutter context where things run, but IIRC this particular test does not render a map or anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not blocking for this review, but when I tried to do a Wasm build of the google maps' example app for web, I still get some errors coming from the google_maps package:
Error: Dart library 'dart:web_gl' is not available on this platform.
library 'package:js/js.dart' can't be imported when compiling to Wasm.
library 'package:js/js_util.dart' can't be imported when compiling to Wasm.
'package:js/js.dart' can't be imported when compiling to Wasm.
'package:js/js_util.dart' can't be imported when compiling to Wasm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we file a tracking issue for google_maps WASM support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should, compiling to
--wasm
is the main goal of this migration.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/FYI @kevmoo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah 💩 . Ugh...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a14n/dart-google-maps#125