Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image_picker] Migrates from deprecated UnmodifiableUint8ListView #5248

Closed

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Oct 27, 2023

issue flutter/flutter#137428

This needs to happen for @rakudrama to be able to land his deprecation lint. Flutter doesn't have the necessary version of Dart yet though (3.3.0). Once that happens this should be landed.

Fixes flutter/flutter#143113

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke force-pushed the deprecate-UnmodifiableUint8ListView branch from df8bafb to 7bce649 Compare October 27, 2023 16:42
@stuartmorgan stuartmorgan added the waiting for stable update Can't be landed until functionality reaches the stable channel label Dec 12, 2023
@stuartmorgan stuartmorgan removed the waiting for stable update Can't be landed until functionality reaches the stable channel label Feb 16, 2024
@ditman
Copy link
Member

ditman commented Feb 22, 2024

@gaaclarke I saw this when I had my PR fixing several other deprecated_member_uses in the repo ready, so I pushed mine with all of them together. Thanks for this PR though!

@gaaclarke
Copy link
Member Author

@gaaclarke I saw this when I had my PR fixing several other deprecated_member_uses in the repo ready, so I pushed mine with all of them together. Thanks for this PR though!

sgtm, thanks!

LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
This PR removes a bunch of deprecated APIs from the following packages:

* `web_benchmarks`
* `file_selector_web`
* `cross_file`
* `image_picker_platform_interface`

## Issues

* Fixes flutter/flutter#143113
* Fixes flutter/flutter#143399
* Fixes flutter/flutter#143878
* Fixes flutter/flutter#143892
* Closes flutter#5248
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
This PR removes a bunch of deprecated APIs from the following packages:

* `web_benchmarks`
* `file_selector_web`
* `cross_file`
* `image_picker_platform_interface`

## Issues

* Fixes flutter/flutter#143113
* Fixes flutter/flutter#143399
* Fixes flutter/flutter#143878
* Fixes flutter/flutter#143892
* Closes flutter#5248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove use of deprecated UnmodifiableUint8ListView API in image_picker_platform_interface package
3 participants