Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web_benchmarks] Make package compatible with Chromium v89+ #518

Merged
merged 15 commits into from
Feb 17, 2022
Merged
Prev Previous commit
Next Next commit
Be a smart-ass and attempt to run tests both in old and new Chromium.
ditman committed Feb 16, 2022
commit e3be16281d090aef59acff086ec8f48edd0e4a00
3 changes: 3 additions & 0 deletions .cirrus.yml
Original file line number Diff line number Diff line change
@@ -101,6 +101,9 @@ task:
- format+analyze
- name: web_benchmarks_test
env:
matrix:
CHROMIUM_BUILD: "768968" # Chromium 84.0.4147.0
CHROMIUM_BUILD: "950363" # Chromium 98.0.4758.0
CHROME_NO_SANDBOX: true
install_chromium_script:
- ./script/install_chromium.sh
6 changes: 5 additions & 1 deletion script/install_chromium.sh
Original file line number Diff line number Diff line change
@@ -8,7 +8,11 @@ set -x
# The build of Chromium used to test web functionality.
#
# Chromium builds can be located here: https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Linux_x64/
CHROMIUM_BUILD=768968
#
# Set CHROMIUM_BUILD env-var to let the script know what to download.

: "${CHROMIUM_BUILD:=950363}" # Default value for the CHROMIUM_BUILD env.
echo "Downloading CHROMIUM_BUILD=${CHROMIUM_BUILD}"

mkdir .chromium
wget "https://www.googleapis.com/download/storage/v1/b/chromium-browser-snapshots/o/Linux_x64%2F${CHROMIUM_BUILD}%2Fchrome-linux.zip?alt=media" -O .chromium/chromium.zip