-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linux support to Pigeon #5100
Merged
Merged
Changes from 143 commits
Commits
Show all changes
147 commits
Select commit
Hold shift + click to select a range
4fb2014
Add Linux support
robert-ancell a6fd0b4
Bump minor version as new feature
robert-ancell c019fd7
Fix grammar
robert-ancell 01855bf
Merge remote-tracking branch 'origin/main' into pigeon-linux
robert-ancell a07914f
Factor methods out of writeHostApi
robert-ancell 608bfd6
Inline arg list generation
robert-ancell 3c3c89d
Drop FlValue runtime checks - we generate both sides
robert-ancell 2d85897
Explicitly set module name, moving default into the generator
robert-ancell eae1cb8
Use package name as default module
robert-ancell 2779a61
Fix style of generated code
robert-ancell 361867d
Remove need to lint ignore comment
robert-ancell a6f0e23
Merge remote-tracking branch 'origin/main' into pigeon-linux
robert-ancell 57cad20
Call _getModule less
robert-ancell c80d864
Use self for instance name
robert-ancell c55e3aa
no longer generating checks
robert-ancell 2224622
Fix enum generated code
robert-ancell 32a75d1
Generate missing Flutter API implementation
robert-ancell 68dc918
Change from Indent.addScoped to Indent.writeScoped
robert-ancell d93af34
Fix example compiling
robert-ancell 5c83c03
Fix method call code
robert-ancell c79a035
Generate codecs for Flutter APIs
robert-ancell cedb8fa
Fix example snippets
robert-ancell 24a3523
Merge remote-tracking branch 'origin/main' into pigeon-linux
robert-ancell 7cd8e5c
Rename Linux to GObject
robert-ancell 0b7d07d
Merge branch 'main' into pigeon-linux
robert-ancell ef4ef9f
Compose warning messages dynamically
robert-ancell c77b7b6
Update generated code to use new warnings
robert-ancell d380a50
Support integer list types
robert-ancell fb93d79
update test
robert-ancell b5c1b7d
Fix analyze
robert-ancell 51a294b
Fix void return value cases
robert-ancell 998acd6
Merge remote-tracking branch 'origin/main' into pigeon-linux
robert-ancell f4d41ef
Fix formatting
robert-ancell 14789ce
Fix README snippet
robert-ancell 5705ce9
Add initial nullable type support
robert-ancell a4958b5
Unchanged boilerplate
stuartmorgan 5aadccd
Add licenses to boilerplate
stuartmorgan 84a7d5c
Wire up Linux test suites
stuartmorgan f3a813f
Fix unit test compilation and running
stuartmorgan 6300d08
Add generated files to compilation; currently fails
stuartmorgan ce7f90b
Analyzer fixes
stuartmorgan 617ab2b
Add initial Object support
stuartmorgan ebf30c2
Add generated files
stuartmorgan 42c7c42
Add the new generator type to integration test plumbing
stuartmorgan c17b9a9
Allocate nullable primitives, fix returning them
robert-ancell 21f8965
Update test
robert-ancell f5764cd
Implement Linux tests
robert-ancell a58df6c
Fix generated code
robert-ancell edc875c
Fix generated code
robert-ancell f7b98a3
Fix arg name
robert-ancell 68876e4
Add missing method prefix
robert-ancell 1746a97
Update generated code
robert-ancell 81b8a0c
Fix nullable enums
robert-ancell e4a6b24
Fix array length args
robert-ancell 24c324f
Add another method prefix
robert-ancell 3aaffd7
Test fixes
robert-ancell d3b640e
Fix lists in Flutter API
robert-ancell ac4ce26
Implement more Linux tests
robert-ancell 92d68fa
Mangle reserved method and field names
robert-ancell ceec011
Merge remote-tracking branch 'origin/main' into pigeon-linux
robert-ancell 53c3e74
Move vtable code into section that gets documented
robert-ancell c86c5d1
Fix analyze issues
robert-ancell b5fc376
Connect up more Linux tests
robert-ancell 5652fc9
Merge remote-tracking branch 'origin/main' into pigeon-linux
robert-ancell e8c71d3
Update generated code
robert-ancell e52b54a
Handle errors in tests
robert-ancell fbdb463
Fix usage of fl_value_ref
robert-ancell 607cdad
Another fl_value_ref case
robert-ancell 9515261
Merge branch 'main' into pigeon-linux
stuartmorgan 8a5efbc
Disable each integration test individually as a starting point for br…
stuartmorgan c73b86b
Enable one simple test just to see that it works
stuartmorgan 10f4ea5
Enable some error-throwing tests, which fail but don't hang
stuartmorgan 91064cc
Enable single type sync tests
stuartmorgan 67f7bc5
Enable single type async tests
stuartmorgan b937812
Switch some suites to group disable
stuartmorgan 2cda851
Merge branch 'main' into pigeon-linux
stuartmorgan 97e4a16
Merge branch 'main' into pigeon-linux
robert-ancell 0117910
Update GObject code for new general codec API
robert-ancell e780fc4
Merge branch 'main' into pigeon-linux
robert-ancell bbcb8f5
Fix analyze issues
robert-ancell 9a02193
Update Linux tests to match changes in 2e928d78eafc62dc8b36dfbda2791a…
robert-ancell 8d705c4
Update generated code
robert-ancell 297df34
Add missing type casts
robert-ancell 215e7c2
Replace g_memdup2 with g_memdup - the former is not on the CI
robert-ancell d22bfca
Update generated code
robert-ancell 8152a6b
Add missing casts
robert-ancell 62cd8fb
Codec needs to be namespaced
robert-ancell abef09e
Update generated code
robert-ancell 63cfd33
Fix missing enumeration
robert-ancell dc45410
Regen
robert-ancell 0a3cae7
Replace g_memdup with malloc - works on all versions
robert-ancell f281679
Fix analyze issues
robert-ancell 68396b9
Fix enumerations
robert-ancell eb0df4e
Fix analyze
robert-ancell 17b7c43
Fix null values in errors
robert-ancell 49a5e4a
regen
robert-ancell 1d0250b
Merge remote-tracking branch 'origin/main' into pigeon-linux
robert-ancell 10350a3
Add xvfb wrapper to Linux integration test when run from CI entrypoint
stuartmorgan ea4355a
Fix generated pointer style
robert-ancell d47ce70
Correctly get copyright as per PR review comment
robert-ancell 9c47c47
Respond to small API requests
robert-ancell 6a4a048
Fix echoAllTypes
robert-ancell 09caa2d
Enable working tests
robert-ancell f2c6ec0
Need more work on the small API plugin
robert-ancell a8333d2
Fix invalid custom type IDs
robert-ancell 4dd478d
Fix getting length of null arrays
robert-ancell 041f086
Fix nullable fields
robert-ancell 8480d7c
Enable more tests
robert-ancell 8fdb2fc
Enable more tests
robert-ancell fa41802
Fix analyze
robert-ancell 8c81bbf
Add suffix
robert-ancell b907b93
Enable working tests
robert-ancell 58f53d5
Fix Flutter api calls
robert-ancell a4075bf
Last test working
robert-ancell dcad69a
Merge remote-tracking branch 'origin/main' into pigeon-linux
robert-ancell f18369b
Unused import
robert-ancell fe50981
regen
robert-ancell 2f94b19
Generate documentation comments
robert-ancell 65c12fa
Use an object for the return value from Flutter calls
robert-ancell 52c201b
Update example
robert-ancell eb63316
Merge remote-tracking branch 'origin/main' into pigeon-linux
robert-ancell 9ec2da4
Add real tests
robert-ancell 32b4645
Add test that require a fake messenger
robert-ancell 5c3c82e
Fix str checks in tests
robert-ancell eb185f7
Fix test for updated generated code
robert-ancell 96c7537
Add primitive test
robert-ancell 6ee9fd3
Fix generated code test
robert-ancell 55e2f20
unused variables
robert-ancell e468cb0
Merge remote-tracking branch 'origin/main' into pigeon-linux
robert-ancell e91154e
Set changelog version
robert-ancell 1316e96
Try running unit tests under xvfb
stuartmorgan 67b80a2
Fix test crashes
robert-ancell 2570cde
Fix analyze
robert-ancell 96eb231
Merge remote-tracking branch 'origin/main' into pigeon-linux
robert-ancell 96fa38f
Fix mocked data
robert-ancell 3edd2c5
Merge branch 'main' into pigeon-linux
robert-ancell e168930
Merge remote-tracking branch 'origin/main' into pigeon-linux
robert-ancell ce3829d
Stop the Api object from holding a strong reference to the channels.
robert-ancell c7b4221
Fix code snippet
robert-ancell 8323c6c
Replace host API object with a _set_method_handlers function
robert-ancell d6047f3
Merge remote-tracking branch 'origin/main' into pigeon-linux
robert-ancell fd0fd3b
Fix test
robert-ancell d939e58
Fix snippet
robert-ancell b9e61c3
Merge branch 'main' into pigeon-linux
stuartmorgan 4c474a8
Adopt addDocumentationComments everywhere
stuartmorgan 4c539b5
Clear handlers in test plugin
stuartmorgan 7458f06
Use the right version
stuartmorgan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
flutter/ephemeral |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,140 @@ | ||
# Project-level configuration. | ||
cmake_minimum_required(VERSION 3.10) | ||
project(runner LANGUAGES CXX) | ||
|
||
# The name of the executable created for the application. Change this to change | ||
# the on-disk name of your application. | ||
set(BINARY_NAME "pigeon_example_app") | ||
# The unique GTK application identifier for this application. See: | ||
# https://wiki.gnome.org/HowDoI/ChooseApplicationID | ||
set(APPLICATION_ID "dev.flutter.pigeon_example_app") | ||
|
||
# Explicitly opt in to modern CMake behaviors to avoid warnings with recent | ||
# versions of CMake. | ||
cmake_policy(SET CMP0063 NEW) | ||
|
||
# Load bundled libraries from the lib/ directory relative to the binary. | ||
set(CMAKE_INSTALL_RPATH "$ORIGIN/lib") | ||
|
||
# Root filesystem for cross-building. | ||
if(FLUTTER_TARGET_PLATFORM_SYSROOT) | ||
set(CMAKE_SYSROOT ${FLUTTER_TARGET_PLATFORM_SYSROOT}) | ||
set(CMAKE_FIND_ROOT_PATH ${CMAKE_SYSROOT}) | ||
set(CMAKE_FIND_ROOT_PATH_MODE_PROGRAM NEVER) | ||
set(CMAKE_FIND_ROOT_PATH_MODE_PACKAGE ONLY) | ||
set(CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY) | ||
set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY) | ||
endif() | ||
|
||
# Define build configuration options. | ||
if(NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES) | ||
set(CMAKE_BUILD_TYPE "Debug" CACHE | ||
STRING "Flutter build mode" FORCE) | ||
set_property(CACHE CMAKE_BUILD_TYPE PROPERTY STRINGS | ||
"Debug" "Profile" "Release") | ||
endif() | ||
|
||
# Compilation settings that should be applied to most targets. | ||
# | ||
# Be cautious about adding new options here, as plugins use this function by | ||
# default. In most cases, you should add new options to specific targets instead | ||
# of modifying this function. | ||
function(APPLY_STANDARD_SETTINGS TARGET) | ||
target_compile_features(${TARGET} PUBLIC cxx_std_14) | ||
target_compile_options(${TARGET} PRIVATE -Wall -Werror) | ||
target_compile_options(${TARGET} PRIVATE "$<$<NOT:$<CONFIG:Debug>>:-O3>") | ||
target_compile_definitions(${TARGET} PRIVATE "$<$<NOT:$<CONFIG:Debug>>:NDEBUG>") | ||
endfunction() | ||
|
||
# Flutter library and tool build rules. | ||
set(FLUTTER_MANAGED_DIR "${CMAKE_CURRENT_SOURCE_DIR}/flutter") | ||
add_subdirectory(${FLUTTER_MANAGED_DIR}) | ||
|
||
# System-level dependencies. | ||
find_package(PkgConfig REQUIRED) | ||
pkg_check_modules(GTK REQUIRED IMPORTED_TARGET gtk+-3.0) | ||
|
||
add_definitions(-DAPPLICATION_ID="${APPLICATION_ID}") | ||
|
||
# Define the application target. To change its name, change BINARY_NAME above, | ||
# not the value here, or `flutter run` will no longer work. | ||
# | ||
# Any new source files that you add to the application should be added here. | ||
add_executable(${BINARY_NAME} | ||
"main.cc" | ||
"my_application.cc" | ||
"messages.g.cc" | ||
"${FLUTTER_MANAGED_DIR}/generated_plugin_registrant.cc" | ||
) | ||
|
||
# Apply the standard set of build settings. This can be removed for applications | ||
# that need different build settings. | ||
apply_standard_settings(${BINARY_NAME}) | ||
|
||
# Add dependency libraries. Add any application-specific dependencies here. | ||
target_link_libraries(${BINARY_NAME} PRIVATE flutter) | ||
target_link_libraries(${BINARY_NAME} PRIVATE PkgConfig::GTK) | ||
|
||
# Run the Flutter tool portions of the build. This must not be removed. | ||
add_dependencies(${BINARY_NAME} flutter_assemble) | ||
|
||
# Only the install-generated bundle's copy of the executable will launch | ||
# correctly, since the resources must in the right relative locations. To avoid | ||
# people trying to run the unbundled copy, put it in a subdirectory instead of | ||
# the default top-level location. | ||
set_target_properties(${BINARY_NAME} | ||
PROPERTIES | ||
RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/intermediates_do_not_run" | ||
) | ||
|
||
|
||
# Generated plugin build rules, which manage building the plugins and adding | ||
# them to the application. | ||
include(flutter/generated_plugins.cmake) | ||
|
||
|
||
# === Installation === | ||
# By default, "installing" just makes a relocatable bundle in the build | ||
# directory. | ||
set(BUILD_BUNDLE_DIR "${PROJECT_BINARY_DIR}/bundle") | ||
if(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT) | ||
set(CMAKE_INSTALL_PREFIX "${BUILD_BUNDLE_DIR}" CACHE PATH "..." FORCE) | ||
endif() | ||
|
||
# Start with a clean build bundle directory every time. | ||
install(CODE " | ||
file(REMOVE_RECURSE \"${BUILD_BUNDLE_DIR}/\") | ||
" COMPONENT Runtime) | ||
|
||
set(INSTALL_BUNDLE_DATA_DIR "${CMAKE_INSTALL_PREFIX}/data") | ||
set(INSTALL_BUNDLE_LIB_DIR "${CMAKE_INSTALL_PREFIX}/lib") | ||
|
||
install(TARGETS ${BINARY_NAME} RUNTIME DESTINATION "${CMAKE_INSTALL_PREFIX}" | ||
COMPONENT Runtime) | ||
|
||
install(FILES "${FLUTTER_ICU_DATA_FILE}" DESTINATION "${INSTALL_BUNDLE_DATA_DIR}" | ||
COMPONENT Runtime) | ||
|
||
install(FILES "${FLUTTER_LIBRARY}" DESTINATION "${INSTALL_BUNDLE_LIB_DIR}" | ||
COMPONENT Runtime) | ||
|
||
foreach(bundled_library ${PLUGIN_BUNDLED_LIBRARIES}) | ||
install(FILES "${bundled_library}" | ||
DESTINATION "${INSTALL_BUNDLE_LIB_DIR}" | ||
COMPONENT Runtime) | ||
endforeach(bundled_library) | ||
|
||
# Fully re-copy the assets directory on each build to avoid having stale files | ||
# from a previous install. | ||
set(FLUTTER_ASSET_DIR_NAME "flutter_assets") | ||
install(CODE " | ||
file(REMOVE_RECURSE \"${INSTALL_BUNDLE_DATA_DIR}/${FLUTTER_ASSET_DIR_NAME}\") | ||
" COMPONENT Runtime) | ||
install(DIRECTORY "${PROJECT_BUILD_DIR}/${FLUTTER_ASSET_DIR_NAME}" | ||
DESTINATION "${INSTALL_BUNDLE_DATA_DIR}" COMPONENT Runtime) | ||
|
||
# Install the AOT library on non-Debug builds only. | ||
if(NOT CMAKE_BUILD_TYPE MATCHES "Debug") | ||
install(FILES "${AOT_LIBRARY}" DESTINATION "${INSTALL_BUNDLE_LIB_DIR}" | ||
COMPONENT Runtime) | ||
endif() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
# This file controls Flutter-level build steps. It should not be edited. | ||
cmake_minimum_required(VERSION 3.10) | ||
|
||
set(EPHEMERAL_DIR "${CMAKE_CURRENT_SOURCE_DIR}/ephemeral") | ||
|
||
# Configuration provided via flutter tool. | ||
include(${EPHEMERAL_DIR}/generated_config.cmake) | ||
|
||
# TODO: Move the rest of this into files in ephemeral. See | ||
# https://github.com/flutter/flutter/issues/57146. | ||
|
||
# Serves the same purpose as list(TRANSFORM ... PREPEND ...), | ||
# which isn't available in 3.10. | ||
function(list_prepend LIST_NAME PREFIX) | ||
set(NEW_LIST "") | ||
foreach(element ${${LIST_NAME}}) | ||
list(APPEND NEW_LIST "${PREFIX}${element}") | ||
endforeach(element) | ||
set(${LIST_NAME} "${NEW_LIST}" PARENT_SCOPE) | ||
endfunction() | ||
|
||
# === Flutter Library === | ||
# System-level dependencies. | ||
find_package(PkgConfig REQUIRED) | ||
pkg_check_modules(GTK REQUIRED IMPORTED_TARGET gtk+-3.0) | ||
pkg_check_modules(GLIB REQUIRED IMPORTED_TARGET glib-2.0) | ||
pkg_check_modules(GIO REQUIRED IMPORTED_TARGET gio-2.0) | ||
|
||
set(FLUTTER_LIBRARY "${EPHEMERAL_DIR}/libflutter_linux_gtk.so") | ||
|
||
# Published to parent scope for install step. | ||
set(FLUTTER_LIBRARY ${FLUTTER_LIBRARY} PARENT_SCOPE) | ||
set(FLUTTER_ICU_DATA_FILE "${EPHEMERAL_DIR}/icudtl.dat" PARENT_SCOPE) | ||
set(PROJECT_BUILD_DIR "${PROJECT_DIR}/build/" PARENT_SCOPE) | ||
set(AOT_LIBRARY "${PROJECT_DIR}/build/lib/libapp.so" PARENT_SCOPE) | ||
|
||
list(APPEND FLUTTER_LIBRARY_HEADERS | ||
"fl_basic_message_channel.h" | ||
"fl_binary_codec.h" | ||
"fl_binary_messenger.h" | ||
"fl_dart_project.h" | ||
"fl_engine.h" | ||
"fl_json_message_codec.h" | ||
"fl_json_method_codec.h" | ||
"fl_message_codec.h" | ||
"fl_method_call.h" | ||
"fl_method_channel.h" | ||
"fl_method_codec.h" | ||
"fl_method_response.h" | ||
"fl_plugin_registrar.h" | ||
"fl_plugin_registry.h" | ||
"fl_standard_message_codec.h" | ||
"fl_standard_method_codec.h" | ||
"fl_string_codec.h" | ||
"fl_value.h" | ||
"fl_view.h" | ||
"flutter_linux.h" | ||
) | ||
list_prepend(FLUTTER_LIBRARY_HEADERS "${EPHEMERAL_DIR}/flutter_linux/") | ||
add_library(flutter INTERFACE) | ||
target_include_directories(flutter INTERFACE | ||
"${EPHEMERAL_DIR}" | ||
) | ||
target_link_libraries(flutter INTERFACE "${FLUTTER_LIBRARY}") | ||
target_link_libraries(flutter INTERFACE | ||
PkgConfig::GTK | ||
PkgConfig::GLIB | ||
PkgConfig::GIO | ||
) | ||
add_dependencies(flutter flutter_assemble) | ||
|
||
# === Flutter tool backend === | ||
# _phony_ is a non-existent file to force this command to run every time, | ||
# since currently there's no way to get a full input/output list from the | ||
# flutter tool. | ||
add_custom_command( | ||
OUTPUT ${FLUTTER_LIBRARY} ${FLUTTER_LIBRARY_HEADERS} | ||
${CMAKE_CURRENT_BINARY_DIR}/_phony_ | ||
COMMAND ${CMAKE_COMMAND} -E env | ||
${FLUTTER_TOOL_ENVIRONMENT} | ||
"${FLUTTER_ROOT}/packages/flutter_tools/bin/tool_backend.sh" | ||
${FLUTTER_TARGET_PLATFORM} ${CMAKE_BUILD_TYPE} | ||
VERBATIM | ||
) | ||
add_custom_target(flutter_assemble DEPENDS | ||
"${FLUTTER_LIBRARY}" | ||
${FLUTTER_LIBRARY_HEADERS} | ||
) |
23 changes: 23 additions & 0 deletions
23
packages/pigeon/example/app/linux/flutter/generated_plugins.cmake
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# | ||
# Generated file, do not edit. | ||
# | ||
|
||
list(APPEND FLUTTER_PLUGIN_LIST | ||
) | ||
|
||
list(APPEND FLUTTER_FFI_PLUGIN_LIST | ||
) | ||
|
||
set(PLUGIN_BUNDLED_LIBRARIES) | ||
|
||
foreach(plugin ${FLUTTER_PLUGIN_LIST}) | ||
add_subdirectory(flutter/ephemeral/.plugin_symlinks/${plugin}/linux plugins/${plugin}) | ||
target_link_libraries(${BINARY_NAME} PRIVATE ${plugin}_plugin) | ||
list(APPEND PLUGIN_BUNDLED_LIBRARIES $<TARGET_FILE:${plugin}_plugin>) | ||
list(APPEND PLUGIN_BUNDLED_LIBRARIES ${${plugin}_bundled_libraries}) | ||
endforeach(plugin) | ||
|
||
foreach(ffi_plugin ${FLUTTER_FFI_PLUGIN_LIST}) | ||
add_subdirectory(flutter/ephemeral/.plugin_symlinks/${ffi_plugin}/linux plugins/${ffi_plugin}) | ||
list(APPEND PLUGIN_BUNDLED_LIBRARIES ${${ffi_plugin}_bundled_libraries}) | ||
endforeach(ffi_plugin) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 20.1.0 and Adds GObject lines should be their own entry, not merged with the previous