Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xdg_directories] Remove process dependency #4460

Merged
merged 1 commit into from
Jul 14, 2023
Merged

[xdg_directories] Remove process dependency #4460

merged 1 commit into from
Jul 14, 2023

Conversation

stuartmorgan
Copy link
Contributor

Replaces the process dependency with direct use of io.Process, to reduce external dependencies, since this is a path_provider dependency and thus a core package.

Fixes flutter/flutter#129787

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan
[xdg_directories] Remove process dependency
adfb789 
Replaces the `process` dependency with direct use of `io.Process`, to
reduce external dependencies, since this is a `path_provider` dependency
and thus a core package.

Fixes flutter/flutter#129787
gspencergoog
gspencergoog approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Thanks for doing this. Seems like a good idea all around.

@stuartmorgan stuartmorgan added autosubmit Merge PR when tree becomes green via auto submit App warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. labels Jul 13, 2023
@stuartmorgan
Copy link
Contributor Author

Overriding stale tree status check.

@auto-submit auto-submit bot merged commit b166a0f into flutter:main Jul 14, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
b166a0f [xdg_directories] Remove process dependency (flutter/packag…
c095b56 
…es#4460)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
b166a0f [xdg_directories] Remove process dependency (flutter/packag…
100c1f2 
…es#4460)
@reidbaker reidbaker mentioned this pull request Jul 14, 2023
Merged
11 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
b166a0f [xdg_directories] Remove process dependency (flutter/packag…
fea5a25 
…es#4460)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
Roll Packages from aa1eace to 369ee7e (10 revisions) (#130605)
41d137f 
flutter/packages@aa1eace...369ee7e

2023-07-14 [email protected] [Tool] New tool to download android dependencies  (flutter/packages#4408)
2023-07-14 [email protected] [video_player] added iOS exception on incorrect asset path (flutter/packages#4318)
2023-07-14 [email protected] [google_maps_flutter_platform_interface] Add support for cloud-based map styling (flutter/packages#4141)
2023-07-14 [email protected] [webview_flutter] Adds support for receiving a url with WebResourceError (flutter/packages#3884)
2023-07-14 [email protected] [xdg_directories] Remove `process` dependency (flutter/packages#4460)
2023-07-13 [email protected] [various] Update Pigeon in Swift plugins (flutter/packages#4461)
2023-07-13 [email protected] Roll Flutter from 544d30d to c40173f (10 revisions) (flutter/packages#4457)
2023-07-13 [email protected] Roll Flutter (stable) from 796c8ef to f468f33 (2 revisions) (flutter/packages#4456)
2023-07-13 [email protected] Fix Router Config Issues #4300 (go_router_builder/example)  (flutter/packages#4369)
2023-07-13 [email protected] [webview_flutter_platform_interface] Adds url to `WebResourceError` (flutter/packages#4439)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@engine-flutter-autoroll @LouiseHsu
Roll Packages from aa1eace to 369ee7e (10 revisions) (flutter#130605)
5e100a1 
flutter/packages@aa1eace...369ee7e

2023-07-14 [email protected] [Tool] New tool to download android dependencies  (flutter/packages#4408)
2023-07-14 [email protected] [video_player] added iOS exception on incorrect asset path (flutter/packages#4318)
2023-07-14 [email protected] [google_maps_flutter_platform_interface] Add support for cloud-based map styling (flutter/packages#4141)
2023-07-14 [email protected] [webview_flutter] Adds support for receiving a url with WebResourceError (flutter/packages#3884)
2023-07-14 [email protected] [xdg_directories] Remove `process` dependency (flutter/packages#4460)
2023-07-13 [email protected] [various] Update Pigeon in Swift plugins (flutter/packages#4461)
2023-07-13 [email protected] Roll Flutter from 544d30d to c40173f (10 revisions) (flutter/packages#4457)
2023-07-13 [email protected] Roll Flutter (stable) from 796c8ef to f468f33 (2 revisions) (flutter/packages#4456)
2023-07-13 [email protected] Fix Router Config Issues flutter#4300 (go_router_builder/example)  (flutter/packages#4369)
2023-07-13 [email protected] [webview_flutter_platform_interface] Adds url to `WebResourceError` (flutter/packages#4439)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: xdg_directories warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[xdg_directories] Remove process dependency
2 participants
@stuartmorgan @gspencergoog