Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tool] Add a flag to skip cleanup #4357

Merged

Conversation

stuartmorgan
Copy link
Contributor

It can be useful in debugging snippet setup to look at the extraction output, but the tool cleans that up automatically. Running the extraction manually is complicated due to the on-the-fly pubspec modifications, so this adds a --no-cleanup flag that can be used to skip the deletion of the extraction output, and instead log its location to the terminal.

It can be useful in debugging snippet setup to look at the extraction
output, but the tool cleans that up automatically. Running the
extraction manually is complicated due to the on-the-fly pubspec
modifications, so this adds a `--no-cleanup` flag that can be used to
skip the deletion of the extraction output, and instead log its location
to the terminal.
@stuartmorgan stuartmorgan requested a review from Hixie July 1, 2023 01:09
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 1, 2023

auto label is removed for flutter/packages, pr: 4357, due to - The status or check suite android-platform_tests CHANNEL:master PACKAGE_SHARDING:--shardIndex 2 --shardCount 8 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2023
@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2023
@auto-submit auto-submit bot merged commit 8b3b1ef into flutter:main Jul 1, 2023
@stuartmorgan stuartmorgan deleted the tool-excerpt-no-cleanup-flag branch July 1, 2023 10:54
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 3, 2023
flutter/packages@53ed5a0...cdae854

2023-07-01 [email protected] Roll Flutter from ff838bc to aa5f4a2 (29 revisions) (flutter/packages#4363)
2023-07-01 [email protected] [tool] Add a flag to skip cleanup (flutter/packages#4357)
2023-07-01 [email protected] [file_selector] Endorse Android (flutter/packages#4329)
2023-07-01 [email protected] [google_sign_in] Convert Android to Pigeon (flutter/packages#4344)
2023-06-30 [email protected] [Pigeon] readme updates (flutter/packages#3705)
2023-06-30 [email protected] [camera_android] Support concurrently image capture and image streaming (flutter/packages#4332)
2023-06-30 [email protected] Prepare for utf8.encode() to return more precise Uint8List type (flutter/packages#4342)
2023-06-30 [email protected] [shared_preferences] Adds allowList to setPrefix method. (flutter/packages#3794)
2023-06-30 [email protected] Roll Flutter from 51bef1b to ff838bc (12 revisions) (flutter/packages#4346)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants