Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[path_provider_windows], [path_provider_linux], [path_provider_platform_interface] update dependencies #3818

Closed
wants to merge 1 commit into from
Closed

[path_provider_windows], [path_provider_linux], [path_provider_platform_interface] update dependencies #3818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/path_provider/path_provider_linux/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 2.1.10

environment:
sdk: ">=2.17.0 <4.0.0"
sdk: ">=2.19.0 <4.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would prevent Flutter 3.0 and 3.3 users from using this package, without any benefit.

flutter: ">=3.0.0"

flutter:
Expand All @@ -16,12 +16,12 @@ flutter:
dartPluginClass: PathProviderLinux

dependencies:
ffi: ">=1.1.2 <3.0.0"
ffi: ">=2.0.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes compatibility with ffi 1.x without any benefit, creating more potential conflicts in the ecosystem.

flutter:
sdk: flutter
path: ^1.8.0
path_provider_platform_interface: ^2.0.0
xdg_directories: ">=0.2.0 <2.0.0"
path: ^1.8.2
path_provider_platform_interface: ^2.0.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing in this package requires these bugfix versions; this artificially prevents clients from using earlier versions if they have a specific need to do so.

xdg_directories: ">=1.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes compatibility with version 0.2.0 for no reason (the APIs are identical), creating more potential conflicts in the ecosystem.


dev_dependencies:
flutter_test:
Expand Down
6 changes: 3 additions & 3 deletions packages/path_provider/path_provider_platform_interface/pubspec.yaml
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the same comments apply to the other files as well.

Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 2.0.6

environment:
sdk: ">=2.17.0 <4.0.0"
sdk: ">=2.19.0 <4.0.0"
flutter: ">=3.0.0"

dependencies:
flutter:
sdk: flutter
platform: ^3.0.0
plugin_platform_interface: ^2.1.0
platform: ^3.1.0
plugin_platform_interface: ^2.1.4

dev_dependencies:
flutter_test:
Expand Down
2 changes: 1 addition & 1 deletion packages/path_provider/path_provider_windows/example/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Demonstrates how to use the path_provider plugin.
publish_to: none

environment:
sdk: ">=2.17.0 <4.0.0"
sdk: ">=2.19.0 <4.0.0"
flutter: ">=3.0.0"

dependencies:
Expand Down
10 changes: 5 additions & 5 deletions packages/path_provider/path_provider_windows/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 2.1.5

environment:
sdk: ">=2.17.0 <4.0.0"
sdk: ">=2.19.0 <4.0.0"
flutter: ">=3.0.0"

flutter:
Expand All @@ -16,12 +16,12 @@ flutter:
dartPluginClass: PathProviderWindows

dependencies:
ffi: ^2.0.0
ffi: ^2.0.1
flutter:
sdk: flutter
path: ^1.8.0
path_provider_platform_interface: ^2.0.0
win32: ">=2.1.0 <4.0.0"
path: ^1.8.2
path_provider_platform_interface: ^2.0.6
win32: "^4.1.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unnecessarily removes compatibility with win32 2.x and 3.x, creating more potential conflicts in the ecosystem.


dev_dependencies:
flutter_test:
Expand Down