Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pigeon] Update for compatibility with a future change to the analyzer. #3789

Merged
merged 2 commits into from
Apr 21, 2023
Merged

[pigeon] Update for compatibility with a future change to the analyzer. #3789

merged 2 commits into from
Apr 21, 2023

Conversation

scheglov
Copy link
Contributor

We would like to make a change to the Dart analyzer, but the code in pigeon is written in a way that is not compatible with the future change. https://dart-review.googlesource.com/c/sdk/+/294920

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@scheglov scheglov requested a review from tarrinneal as a code owner April 21, 2023 17:29
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Apr 21, 2023

test-exempt: code refactor with no semantic change

@tarrinneal tarrinneal added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Apr 21, 2023
@scheglov scheglov merged commit 0939198 into flutter:main Apr 21, 2023
@scheglov scheglov deleted the pigeon-future-analyzer branch April 21, 2023 20:16
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
0939198 [pigeon] Update for compatibility with a future change to the…
96166d8 
… analyzer. (flutter/packages#3789)
pro100andrey added a commit to pro100andrey/packages that referenced this pull request Apr 25, 2023
@pro100andrey
Merge branch 'main' into feature/fix
1263b0f 
* main: (144 commits)
  Update test golden images for the latest Skia roll (flutter#3787)
  [various] Adds Android namespace (flutter#3791)
  [shared_preferences] Update gradle/agp in example apps (flutter#3809)
  [go_router] Adds name to TypedGoRoute (flutter#3702)
  [webview_flutter] Adds support to receive permission requests (flutter#3543)
  [google_sign_in] Fix Android Java warnings (flutter#3762)
  [local_auth] Fix enum return on Android (flutter#3780)
  [pigeon] Warn when trying to use enums in collections (flutter#3782)
  [webview_flutter_android] [webview_flutter_wkwebview] Platform implementations for supporting permission requests (flutter#3792)
  [pigeon] Update for compatibility with a future change to the analyzer. (flutter#3789)
  [camera_android] Fix Android lint warnings  (flutter#3716)
  [webview_flutter_platform_interface] Adds method to receive permission requests (flutter#3767)
  [image_picker_ios] In unit test write and read kCGImagePropertyExifUserComment property (flutter#3783)
  [go_router_builder] Fixed the return value of the generated push method (flutter#3650)
  [image_picker] Mention `launchMode: singleInstance` in README (flutter#3759)
  Revert "[pigeon] Add an initial example app" (flutter#3785)
  [google_maps_flutter] Add examples for different iOS versions (flutter#3757)
  [pigeon] Add an initial example app (flutter#3761)
  [google_maps_flutter_web] Allow marker position updates (flutter#3697)
  [Tool] [Code Excerpt] allow excerpts in example readme (flutter#3758)
  ...

# Conflicts:
#	packages/camera/camera/pubspec.yaml
@reidbaker reidbaker mentioned this pull request Apr 25, 2023
Merged
11 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2023
@engine-flutter-autoroll
0939198 [pigeon] Update for compatibility with a future change to the…
83bd9aa 
… analyzer. (flutter/packages#3789)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2023
@engine-flutter-autoroll
0939198 [pigeon] Update for compatibility with a future change to the…
6d104cc 
… analyzer. (flutter/packages#3789)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 1, 2023
@engine-flutter-autoroll
Roll Packages from 7e3f5da to de6131d (41 revisions) (#125811)
ff248d2 
Roll Packages from 7e3f5da to de6131d (41 revisions)

flutter/packages@7e3f5da...de6131d

2023-05-01 [email protected] I122213 update non examples (flutter/packages#3846)
2023-04-29 [email protected] [go_router] Cleans up route match API and introduces dart fix (flutter/packages#3819)
2023-04-29 [email protected] [camerax] Add `LifecycleOwner` Proxy (flutter/packages#3837)
2023-04-29 [email protected] [file_selector] Add getDirectoryPaths implementation for Windows (flutter/packages#3704)
2023-04-29 [email protected] [various] Update Android example min SDKs (flutter/packages#3847)
2023-04-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.2.12 to 2.3.2 (flutter/packages#3838)
2023-04-28 [email protected] [camerax] Implement Image Streaming (flutter/packages#3454)
2023-04-28 [email protected] [various] update agp and gradle for all examples in packages (flutter/packages#3822)
2023-04-28 [email protected] Update xcode to 14c18 (flutter/packages#3774)
2023-04-28 [email protected] [camera_android] Add NV21 as an image stream format #3277 (flutter/packages#3639)
2023-04-28 [email protected] [go_router] Remove unused navigator keys (flutter/packages#3708)
2023-04-28 [email protected] [image_picker] Move I/O operations to a separate thread (flutter/packages#3506)
2023-04-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.20 to 1.8.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#3824)
2023-04-28 [email protected] [pigeon] Reland: Add an initial example app (flutter/packages#3832)
2023-04-28 [email protected] Roll Flutter from c9004ff to 66fa4c5 (68 revisions) (flutter/packages#3830)
2023-04-28 [email protected] [various] Conditionalize the namespace in all Android plugins (flutter/packages#3836)
2023-04-27 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.billingclient:billing from 5.1.0 to 5.2.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#3672)
2023-04-27 [email protected] [auick_action_ios] Retries multiple times to not fail ci when there is a flake (flutter/packages#3823)
2023-04-26 [email protected] Swap some iOS package CODEOWNERS (flutter/packages#3793)
2023-04-26 [email protected] [various] Add `targetCompatibility` to build.gradle (flutter/packages#3825)
2023-04-26 [email protected] [various] Set cmake_policy versions (flutter/packages#3828)
2023-04-26 [email protected] [path_provider] Allow `win32` up to version 4.x (flutter/packages#3820)
2023-04-26 [email protected] [tool] Move Android lint checks (flutter/packages#3816)
2023-04-25 [email protected] [google_maps_flutter_android] Fix Android lint warnings (flutter/packages#3751)
2023-04-25 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.5.0 to 1.6.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#3381)
2023-04-25 [email protected] Update test golden images for the latest Skia roll (flutter/packages#3787)
2023-04-25 [email protected] [various] Adds Android namespace (flutter/packages#3791)
2023-04-25 [email protected] [shared_preferences] Update gradle/agp in example apps (flutter/packages#3809)
2023-04-24 [email protected] [go_router] Adds name to TypedGoRoute (flutter/packages#3702)
2023-04-22 [email protected] [webview_flutter] Adds support to receive permission requests (flutter/packages#3543)
2023-04-21 [email protected] [google_sign_in] Fix Android Java warnings (flutter/packages#3762)
2023-04-21 [email protected] [local_auth] Fix enum return on Android (flutter/packages#3780)
2023-04-21 [email protected] [pigeon] Warn when trying to use enums in collections (flutter/packages#3782)
2023-04-21 [email protected] [webview_flutter_android] [webview_flutter_wkwebview] Platform implementations for supporting permission requests (flutter/packages#3792)
2023-04-21 [email protected] [pigeon] Update for compatibility with a future change to the analyzer. (flutter/packages#3789)
2023-04-21 [email protected] [camera_android] Fix Android lint warnings  (flutter/packages#3716)
2023-04-21 [email protected] [webview_flutter_platform_interface] Adds method to receive permission requests (flutter/packages#3767)
2023-04-21 [email protected] [image_picker_ios] In unit test write and read kCGImagePropertyExifUserComment property (flutter/packages#3783)
2023-04-21 [email protected] [go_router_builder] Fixed the return value of the generated push method (flutter/packages#3650)
2023-04-21 [email protected] [image_picker] Mention `launchMode: singleInstance` in README (flutter/packages#3759)
2023-04-21 [email protected] Revert "[pigeon] Add an initial example app" (flutter/packages#3785)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
...
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@scheglov @nploi
[pigeon] Update for compatibility with a future change to the analyze…
e3e2461 
…r. (flutter#3789)

We would like to make a change to the Dart analyzer, but the code in
pigeon is written in a way that is not compatible with the future
change. https://dart-review.googlesource.com/c/sdk/+/294920

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [relevant style guides] and ran the
auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
repo does use `dart format`.)
- [ ] I signed the [CLA].
- [ ] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated `pubspec.yaml` with an appropriate new version according
to the [pub versioning philosophy], or this PR is [exempt from version
changes].
- [ ] I updated `CHANGELOG.md` to add a description of the change,
[following repository CHANGELOG style].
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[relevant style guides]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[pub versioning philosophy]: https://dart.dev/tools/pub/versioning
[exempt from version changes]:
https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version-and-changelog-updates
[following repository CHANGELOG style]:
https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrinneal tarrinneal tarrinneal approved these changes

Assignees
No one assigned
Labels
needs tests override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: pigeon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scheglov @Hixie @tarrinneal