-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[image_picker] Move I/O operations to a separate thread #3506
Merged
auto-submit
merged 10 commits into
flutter:main
from
JeroenWeener:enhancement/offload-io-to-separate-thread
Apr 28, 2023
+276
−50
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f1892ea
Offloads result handling to separate thread
JeroenWeener aeff575
Add tests
JeroenWeener 7cfc713
Update version and changelog
JeroenWeener 06983b4
Format files
JeroenWeener 2cba265
Restructure onActivityResult logic
JeroenWeener 7fa1101
Synchronize `setPendingOptionsAndResult`
JeroenWeener b3e32b1
Remove unused imports
JeroenWeener 38e67c1
Synchronize thread-unsafe code
JeroenWeener f42d307
Format `ImagePickerDelegate.java`
JeroenWeener 557bf02
Re-bump version
stuartmorgan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this meant to be handleRunnable? or is this a runnable handler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a
Runnable
running a handler function (handleChooseImageResult
etc.). WouldrunnableHandler
make more sense in your opinion?