[pigeon] Fixed decoding code for null-safe classes. #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
force-pushed
the
pigeon-decode-null-safe
branch
2 times, most recently
from
97ab024 to
8a8132c
Compare
11 tasks
gaaclarke
force-pushed
the
pigeon-decode-null-safe
branch
from
8a8132c to
ccaf34b
Compare
gaaclarke
force-pushed
the
pigeon-decode-null-safe
branch
from
ccaf34b to
6a36235
Compare
gaaclarke
commented
Feb 22, 2021
Comment on lines
+181
to
+185
| return 'List<Object$nullTag>$nullTag'; | ||
| case 'Map': | ||
| return 'Map<Object$nullTag, Object$nullTag>'; | ||
| return 'Map<Object$nullTag, Object$nullTag>$nullTag'; | ||
| default: | ||
| return dataType; | ||
| return '$dataType$nullTag'; |
There was a problem hiding this comment.
This is the actual fix, other stuff is just testing infrastructure / tests.
gaaclarke
commented
Feb 22, 2021
Comment on lines
+1
to
+4
| // Autogenerated from Pigeon (v0.1.21), do not edit directly. | ||
| // See also: https://pub.dev/packages/pigeon | ||
| // ignore_for_file: public_member_api_docs, non_constant_identifier_names, avoid_as, unused_import | ||
| // @dart = 2.12 |
There was a problem hiding this comment.
I had to add this file otherwise CI analysis steps fail.
There was a problem hiding this comment.
Maybe, we disable the analysis for flutter_null_safe_unit_tests? https://dart.dev/guides/language/analysis-options#the-analysis-options-file
There was a problem hiding this comment.
Thanks for the pointer. I'm on the fence as to whether it is a good idea or not. I think I'll keep it this way for now.
|
Let me add @blasten to this review, he pointed yesterday to the code you're touching here! |
blasten
approved these changes
Feb 22, 2021
stuartmorgan
pushed a commit
to stuartmorgan/packages
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: flutter/flutter#76405
Pre-launch Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy.CHANGELOG.mdto add a description of the change.///).If you need help, consider asking for advice on the
#hackers-newchannel on Discord.