Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go_router] Nested stateful navigation with ShellRoute #2650

Closed
wants to merge 159 commits into from

Commits on Sep 30, 2022

  1. Configuration menu
    Copy the full SHA
    fa4c542 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    76b17ae View commit details
    Browse the repository at this point in the history
  3. Formatting.

    tolo committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    7612a55 View commit details
    Browse the repository at this point in the history
  4. Formatting.

    Added (and fixed) animation when switching tabs.
    tolo committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    62574bd View commit details
    Browse the repository at this point in the history
  5. Removed NestedNavigationShellRoute and replaced it with new field `ne…

    …stedNavigationBuilder` on ShellRoute.
    
    Added unit test.
    Added reference to example in readme.
    tolo committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    850f41a View commit details
    Browse the repository at this point in the history
  6. Rebased onto upstream/main.

    Conflicts:
    packages/go_router/CHANGELOG.md
    packages/go_router/pubspec.yaml
    tolo committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    1c04588 View commit details
    Browse the repository at this point in the history
  7. Fixed typos.

    tolo committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    1db6bba View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6028c90 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5f2e995 View commit details
    Browse the repository at this point in the history
  10. Updated example to use nested ShellRoutes instead of creating nested …

    …navigators manually.
    
    Renamed example file to stateful_nested_navigation.dart.
    tolo committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    461efd9 View commit details
    Browse the repository at this point in the history
  11. Refactored support for nested stateful navigation - introduced new ro…

    …ute class PartitionedShellRoute as well new base class (ShellRouteBase) shared with ShellRoute.
    
    Introduced new widget (StackedNavigationScaffold) for building stacked, stateful navigation based on an IndexStack, as well as factory constructor (stackedNavigation) for this on PartitionedShellRoute.
    tolo committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    0315e1a View commit details
    Browse the repository at this point in the history
  12. Some renaming.

    tolo committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    510ec34 View commit details
    Browse the repository at this point in the history
  13. Changed the way currentLocation is calculated since it currently does…

    …n't seem possible to use GoRouterState for this (after performing pop at least).
    
    Made transitionDuration optional instead of using default value.
    tolo committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    e82647a View commit details
    Browse the repository at this point in the history
  14. Minor cleanup and refactoring.

    tolo committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    e38fa32 View commit details
    Browse the repository at this point in the history
  15. Renamed StackedNavigationScaffold to StackedNavigationShell.

    Minor clean up, assertion and doc updates.
    tolo committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    f38b9bf View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    89f1dd7 View commit details
    Browse the repository at this point in the history
  17. Added more detail

    tolo committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    3a00a54 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    b0a6264 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    b729d64 View commit details
    Browse the repository at this point in the history
  20. Fix test

    johnpryan committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    3b3909f View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2022

  1. Configuration menu
    Copy the full SHA
    f0b2a1b View commit details
    Browse the repository at this point in the history
  2. Introduced the method navigatorKeyForChildRoute on ShellRouteBase t…

    …o simplify and make the way a navigator is fetched for a shell route more clean. Also removed the need to specify parentNavigatorKey for children of PartitionedShellRoute (navigatorKeys is now the source of truth for navigation keys).
    
    Added more asserts to PartitionedShellRoute and updated docs.
    Renamed field navigationKeys to navigatorKeys on PartitionedShellRoute.
    tolo committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    eb6d4d3 View commit details
    Browse the repository at this point in the history
  3. Added a canPop test for PartitionedShellRoute (by replacing a duplica…

    …ted test for ShellRoute).
    tolo committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    016be76 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4ae26d7 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Configuration menu
    Copy the full SHA
    4a9889a View commit details
    Browse the repository at this point in the history
  2. Updated documentation of PartitionedShellRoute with examples.

    Minor changes to replace use of GoRoute with RouteBase in collections.
    tolo committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    1f3f01a View commit details
    Browse the repository at this point in the history
  3. Updated documentation for builder and pageBuilder fields of ShellRout…

    …eBase, to more correctly describe meaning of the child argument in the builder functions.
    tolo committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    3b38641 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d701ab5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bb6240d View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Configuration menu
    Copy the full SHA
    245d47b View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Refactored PartitionedShellRoute and renamed to StatefulShellRoute.

    StatefulShellRoute now always creates a Widget (StatefulNavigationShell) that manages then nested stateful navigators, and switching between them.
    Details around usage of IndexedStack for managing the stateful navigators are now also hidden.
    tolo committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    bda571b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    da1ea0b View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Configuration menu
    Copy the full SHA
    59c19e7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    723de76 View commit details
    Browse the repository at this point in the history
  3. Fixed CI analyzer issue.

    tolo committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    4c0a91d View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Removed animation support from StatefulNavigationShell and refactored…

    … implementation for support for customizing branch navigator container.
    
    Refactoring (renaming) and documentation updates.
    Updated sample code with example of customization with animations.
    tolo committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    7556965 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ee9bde9 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Configuration menu
    Copy the full SHA
    e9a7029 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    59a6b05 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Merge branch 'main' of github.com:flutter/packages into nested-persis…

    …tent-navigation
    
    Resolved conflicts by bumping version to 5.2.0
    tolo committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    06ab1e9 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2022

  1. Implemented equality in StatefulShellRouteState and ShellRouteBranchS…

    …tate.
    
    Updated the way StatefulNavigationShell manages state.
    Some renaming of fields.
    tolo committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    1b877c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2022

  1. Documentation updates.

    Documentation and api changes related to replacing the term "child route" with "sub-route".
    Removed the need for providing Navigator keys for branches in StatefulShellRoute (falling back to default value in ShellRouteBranch).
    Renamed field pageProvider to pageBuilder in StatefulShellRoute.
    tolo committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    e542a05 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Removed field navigatorKeys from StatefulShellRoute and fixed issue w…

    …ith assert (checkParentNavigatorKeys) of StatefulShellRoute in RouteConfiguration.
    tolo committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    2215a51 View commit details
    Browse the repository at this point in the history
  2. Removed the use of top GoRouterState as a way of getting the current …

    …location for a branch.
    
    Removed/hid redundant fields from StatefulShellRouteState and ShellRouteBranchState.
    Added function goToBranch to StatefulShellRouteState.
    Documentation updates.
    tolo committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    b180653 View commit details
    Browse the repository at this point in the history
  3. Updated example to use the default constructors of StatefulShellRoute…

    … and also added a nested StatefulShellRoute with a TabBar.
    tolo committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    8fdfb82 View commit details
    Browse the repository at this point in the history
  4. Added check when pushing a new route to ensure you cannot push a rout…

    …e that is not a descendant of the current StatefulShellRoute branch.
    
    Minor corrections from PR feedback.
    Fixed broken tests.
    tolo committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    9240ea4 View commit details
    Browse the repository at this point in the history
  5. Minor renaming.

    tolo committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    93bce8e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    20dc0c6 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'main' of github.com:flutter/packages into nested-persis…

    …tent-navigation
    
    # Conflicts:
    #	packages/go_router/CHANGELOG.md
    #	packages/go_router/pubspec.yaml
    tolo committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    376e80f View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Added support for maintaining any extra navigation object passed to t…

    …he current route of a route branch.
    
    Some documentation updates.
    tolo committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    2b2ff91 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Configuration menu
    Copy the full SHA
    5c9fe04 View commit details
    Browse the repository at this point in the history
  2. Added assertion in RouteConfiguration for field defaultLocation of Sh…

    …ellRouteBranch.
    
    Updated assertion when pushing descendants of StatefulShellRoute.
    tolo committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    81e1296 View commit details
    Browse the repository at this point in the history
  3. Added field preloadBranches to StatefulShellRoute, to enable support …

    …for preloading the root routes of the branches.
    tolo committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    59e3b66 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8636bf8 View commit details
    Browse the repository at this point in the history
  5. Various updates from PR feedback:

    - Moved builder and pageBuilder back to ShellRouteBase and updated docs of StatefulShellRoute and ShellRouteBase.
    - Updates in sample code (brought back animation example etc).
    tolo committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    1c509f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2022

  1. Changed the way switching between route branches works - switching is…

    … now done by replacing the current RouteMatchList in GoRouterDelegate instead of navigating via GoRouter.go.
    tolo committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    42c7b7d View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2022

  1. Configuration menu
    Copy the full SHA
    62e7fc1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9a7069a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ae48ede View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. Configuration menu
    Copy the full SHA
    141fdc1 View commit details
    Browse the repository at this point in the history
  2. Reintroduced validation of defaultLocation of StatefulShellRoute (in …

    …RouteConfiguration).
    tolo committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    b6b289f View commit details
    Browse the repository at this point in the history
  3. Merge branch 'main' of github.com:flutter/packages into nested-persis…

    …tent-navigation
    
    # Conflicts:
    #	packages/go_router/CHANGELOG.md
    #	packages/go_router/lib/go_router.dart
    #	packages/go_router/lib/src/builder.dart
    #	packages/go_router/lib/src/delegate.dart
    #	packages/go_router/lib/src/state.dart
    #	packages/go_router/pubspec.yaml
    tolo committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    4d05d99 View commit details
    Browse the repository at this point in the history
  4. Removed replaceMatchList in GoRouterDelegate (using setNewRoutePath i…

    …nstead).
    
    Some cleanup in RouteBuilder.
    tolo committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    d4edd47 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7b9de47 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. Updated ShellRouteBranch to accept list of routes instead of only a s…

    …ingle rootRoute.
    
    Removed convenience constructor StatefulShellRoute.rootRoutes.
    Simplified ShellRouteBranchState a bit.
    Extended support for automatically finding the default route for a branch.
    tolo committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    703815c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9f88928 View commit details
    Browse the repository at this point in the history
  3. Renamed and changed signature of the navigator getters of StatefulShe…

    …llRouteState/ShellRouteBranchState.
    tolo committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    5ca533d View commit details
    Browse the repository at this point in the history
  4. Merge branch 'main' of github.com:flutter/packages into nested-persis…

    …tent-navigation
    
    # Conflicts:
    #	packages/go_router/CHANGELOG.md
    #	packages/go_router/pubspec.yaml
    tolo committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    f5f0ecb View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. Added temporary workaround due to duplication of encodedParams of Rou…

    …teMatches in redirection.dart.
    tolo committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    4a2eac3 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' of github.com:flutter/packages into nested-persis…

    …tent-navigation
    
    # Conflicts:
    #	packages/go_router/CHANGELOG.md
    #	packages/go_router/lib/src/route.dart
    #	packages/go_router/pubspec.yaml
    tolo committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    fc7bd54 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Refactoring of StatefulShellRoute to support dynamic branches, as wel…

    …l as an attempt to simplify API/usage.
    tolo committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    a65f9df View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' of github.com:flutter/packages into nested-persis…

    …tent-navigation
    
    # Conflicts:
    #	packages/go_router/CHANGELOG.md
    #	packages/go_router/lib/src/builder.dart
    #	packages/go_router/lib/src/configuration.dart
    #	packages/go_router/lib/src/delegate.dart
    #	packages/go_router/lib/src/matching.dart
    #	packages/go_router/lib/src/redirection.dart
    #	packages/go_router/lib/src/router.dart
    #	packages/go_router/test/builder_test.dart
    tolo committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    816acb2 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Introduced an internal branch Navigator proxy widget to make the API …

    …simpler (always returning a concrete Widget for each branch).
    
    Added temporary workaround to get correct pop behaviour.
    tolo committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    ee2a845 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    89b82c5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    90b9d62 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Reduced unnecessary rebuilds of child Widgets of StatefulShellRoute, …

    …by caching branch Navigators.
    
    Added equality and hashcode to RouteMatchList and RouteMatch.
    Update stateful_shell_route.dart example with support (AppRouterProvider) for obtaining a reference to the GoRouter, without causing rebuilds.
    tolo committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    7392264 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c0253f6 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. Merge branch 'main' of github.com:flutter/packages into nested-persis…

    …tent-navigation.
    
    # Conflicts:
    #	packages/go_router/CHANGELOG.md
    #	packages/go_router/lib/src/builder.dart
    #	packages/go_router/lib/src/delegate.dart
    #	packages/go_router/pubspec.yaml
    tolo committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    2c4afa1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    845c052 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Fixed issue in StatefulShellBranch.isBranchFor (accidental use of inc…

    …orrect field of GoRouterState).
    
    Added unit tests for StatefulShellBranch.isBranchFor as well as for StatefulShellRouteState.goBranch.
    Fixed typos in documentation.
    tolo committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    193a267 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' of github.com:flutter/packages into nested-persis…

    …tent-navigation
    
    # Conflicts:
    #	packages/go_router/CHANGELOG.md
    #	packages/go_router/lib/src/matching.dart
    #	packages/go_router/pubspec.yaml
    tolo committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    37c4969 View commit details
    Browse the repository at this point in the history
  3. Reverted workaround regarding pop.

    Introduced UnmodifiableRouteMatchList (mostly due to mutability changes in RouteMatchList).
    tolo committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    c562482 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    38b5772 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    db22bac View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Configuration menu
    Copy the full SHA
    d8d1641 View commit details
    Browse the repository at this point in the history
  2. Additional rebuild improvement.

    Added isLoaded getter to StatefulShellBranchState.
    tolo committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    4c4b7b0 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'main' of github.com:flutter/packages into nested-persis…

    …tent-navigation
    
    # Conflicts:
    #	packages/go_router/CHANGELOG.md
    #	packages/go_router/pubspec.yaml
    tolo committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    f08f548 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Minor documentation fix.

    tolo committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    6f1b047 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    07ee030 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Configuration menu
    Copy the full SHA
    9ffff5c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e9d40ee View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Update packages/go_router/CHANGELOG.md

    Wording fix
    
    Co-authored-by: chunhtai <[email protected]>
    tolo and chunhtai authored Dec 21, 2022
    Configuration menu
    Copy the full SHA
    0ea48cb View commit details
    Browse the repository at this point in the history
  2. Update packages/go_router/CHANGELOG.md

    Wording fix
    
    Co-authored-by: chunhtai <[email protected]>
    tolo and chunhtai authored Dec 21, 2022
    Configuration menu
    Copy the full SHA
    4abcaa9 View commit details
    Browse the repository at this point in the history
  3. Update packages/go_router/CHANGELOG.md

    Wording fix
    
    Co-authored-by: chunhtai <[email protected]>
    tolo and chunhtai authored Dec 21, 2022
    Configuration menu
    Copy the full SHA
    ce23558 View commit details
    Browse the repository at this point in the history
  4. Update packages/go_router/lib/src/route.dart

    Documentation wording fix
    
    Co-authored-by: chunhtai <[email protected]>
    tolo and chunhtai authored Dec 21, 2022
    Configuration menu
    Copy the full SHA
    351ceb2 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. Partially reverted the StatefulShellRoute API back to the previous so…

    …lution with static branches.
    tolo committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    4cb0f1e View commit details
    Browse the repository at this point in the history
  2. Documentation updates and some renaming.

    Minor cleanup/refactoring in RouteBuilder/StatefulNavigationShell.
    tolo committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    e6a4f71 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'main' of github.com:flutter/packages into nested-persis…

    …tent-navigation
    
    # Conflicts:
    #	packages/go_router/CHANGELOG.md
    #	packages/go_router/pubspec.yaml
    tolo committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    873bf34 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5b668f8 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Configuration menu
    Copy the full SHA
    565c3cd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ee1a8f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    358551f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f9a2608 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Alternative StatefulShellRoute implementation, were either a builder …

    …or pageBuilder can be provided, much like ShellRoute/GoRoute, but with different parameters (StatefulShellFactory).
    tolo committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    87211aa View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Extracted construction of StatefulNavigationShell and Navigators out …

    …from RouteBuilder.
    
    Also reduced interdependencies (from StatefulNavigationShell etc), primarily by using GoRouterState instead of RouteMatchList.
    tolo committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    257a272 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' of github.com:flutter/packages into nested-persis…

    …tent-navigation
    
    # Conflicts:
    #	packages/go_router/CHANGELOG.md
    #	packages/go_router/lib/src/builder.dart
    #	packages/go_router/lib/src/matching.dart
    #	packages/go_router/lib/src/route.dart
    #	packages/go_router/pubspec.yaml
    tolo committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    08148e5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c18941f View commit details
    Browse the repository at this point in the history
  4. Refactored the builder methods of the shell route classes to improve …

    …API ergonomics.
    
    Changed the way the branch child Widgets/Navigators are accessed, by adding the class ShellNavigatorContainer.
    tolo committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    b1ce762 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Various refactoring.

    Updated StatefulShellRouteState.goBranch to only accept index for identifying branch.
    tolo committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    75e43d0 View commit details
    Browse the repository at this point in the history
  2. Minor renaming.

    Removed commented out / obsolete test code.
    tolo committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    9f54b4e View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2023

  1. Configuration menu
    Copy the full SHA
    1226f44 View commit details
    Browse the repository at this point in the history
  2. Updated handling of RouteMatch lookup for pages/routes (replaced Expa…

    …ndo with new class PagePopContext).
    tolo committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    881be86 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'main' of github.com:flutter/packages into nested-persis…

    …tent-navigation
    
    # Conflicts:
    #	packages/go_router/CHANGELOG.md
    #	packages/go_router/pubspec.yaml
    tolo committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    6bbbd29 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Add type annotation to listEquals

    Co-authored-by: chunhtai <[email protected]>
    tolo and chunhtai authored Feb 23, 2023
    Configuration menu
    Copy the full SHA
    fd5412f View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2023

  1. Moved RouteNavigatorBuilder into builder.dart and made private.

    Made PagePopContext private.
    tolo committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    a5234a6 View commit details
    Browse the repository at this point in the history
  2. Moved StatefulNavigationShell and support classes into route.dart and…

    … made private.
    
    Moved implementation details out of StatefulShellRouteState and StatefulShellBranchState, and into private implementation classes in route.dart.
    Reverted changes to GoRouterStateRegistry (no longer needed).
    tolo committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    b9428cb View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Refactoring of StatefulShellRoute and related classes to simplify bui…

    …lder/pageBuilder API (removed InheritedWidget and changed how StatefulShellRouteState is created and used).
    tolo committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    ee047c8 View commit details
    Browse the repository at this point in the history
  2. Re-introduced proper validation of parent Navigator keys for routes i…

    …n StatefulShellBranch.
    tolo committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    ddc71f0 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'main' of github.com:flutter/packages into nested-persis…

    …tent-navigation
    
    # Conflicts:
    #	packages/go_router/CHANGELOG.md
    #	packages/go_router/pubspec.yaml
    tolo committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    5041bea View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    01cce04 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Removed preload support.

    Various refactoring due to review feedback.
    tolo committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    9315373 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    89341ef View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Refactored state management for StatefulShellRoute.

    Removed some obsolete code.
    tolo committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    2c298cd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4c22b53 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Moved branch state management back into StatefulShellRoute and simpli…

    …fied API.
    
    Moved goBranch from GoRouter into StatefulNavigationShellState.
    Added support for proper state restoration to StatefulShellRoute.
    Added support for proper state restoration of imperatively pushed routes.
    Added support for saving and restoring push count for GoRouterDelegate.
    tolo committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    a7d419f View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' of github.com:flutter/packages into nested-persis…

    …tent-navigation
    
    # Conflicts:
    #	packages/go_router/CHANGELOG.md
    #	packages/go_router/lib/src/delegate.dart
    #	packages/go_router/pubspec.yaml
    #	packages/go_router/test/test_helpers.dart
    tolo committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    7285788 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Configuration menu
    Copy the full SHA
    9983887 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' of github.com:flutter/packages into nested-persis…

    …tent-navigation
    
    # Conflicts:
    #	packages/go_router/CHANGELOG.md
    #	packages/go_router/lib/src/delegate.dart
    #	packages/go_router/lib/src/parser.dart
    #	packages/go_router/pubspec.yaml
    tolo committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    ad43837 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3a83007 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2023

  1. Update packages/go_router/lib/src/route.dart

    Co-authored-by: chunhtai <[email protected]>
    tolo and chunhtai authored Apr 15, 2023
    Configuration menu
    Copy the full SHA
    ec6722c View commit details
    Browse the repository at this point in the history
  2. Update packages/go_router/lib/src/route.dart

    Co-authored-by: chunhtai <[email protected]>
    tolo and chunhtai authored Apr 15, 2023
    Configuration menu
    Copy the full SHA
    9bb0da9 View commit details
    Browse the repository at this point in the history
  3. Update packages/go_router/lib/src/route.dart

    Co-authored-by: chunhtai <[email protected]>
    tolo and chunhtai authored Apr 15, 2023
    Configuration menu
    Copy the full SHA
    a1c7a8f View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Removed StackedShellRouteState and moved functionality into StackedNa…

    …vigationShell.
    
    Added navigatorContainerBuilder field to StackedShellRoute.
    Added locationForRoute to GoRouter (and RouteConfiguration).
    Various other refactoring due to review feedback.
    tolo committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    477b47c View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' of github.com:flutter/packages into nested-persis…

    …tent-navigation
    
    # Conflicts:
    #	packages/go_router/CHANGELOG.md
    #	packages/go_router/lib/src/builder.dart
    #	packages/go_router/pubspec.yaml
    tolo committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    7f25f0c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6f35636 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Merge branch 'main' of github.com:flutter/packages into nested-persis…

    …tent-navigation
    
    # Conflicts:
    #	packages/go_router/CHANGELOG.md
    #	packages/go_router/pubspec.yaml
    tolo committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    bb5c08f View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2023

  1. Refactoring due to review feedback.

    Re-introduced StatefulShellRoute as a base class for StackedShellRoute.
    Made effectiveInitialBranchLocation public.
    Removed _GoRouterDelegateRestorableProperties and _RestorablePushCount.
    tolo committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    16c095c View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. Merge branch 'main' of github.com:flutter/packages into nested-persis…

    …tent-navigation
    
    # Conflicts:
    #	packages/go_router/CHANGELOG.md
    #	packages/go_router/lib/src/delegate.dart
    #	packages/go_router/lib/src/match.dart
    #	packages/go_router/lib/src/matching.dart
    #	packages/go_router/pubspec.yaml
    #	packages/go_router/test/builder_test.dart
    #	packages/go_router/test/matching_test.dart
    tolo committed May 1, 2023
    Configuration menu
    Copy the full SHA
    a18a5a5 View commit details
    Browse the repository at this point in the history
  2. Removed matchListEquals from RouteMatchList and replaced with the now…

    … available standard equality check.
    
    Exposed field route in StatefulNavigationShell and StatefulNavigationShellState, for more convenient access to the associated StatefulShellRoute.
    tolo committed May 1, 2023
    Configuration menu
    Copy the full SHA
    abbd01b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0f36623 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Configuration menu
    Copy the full SHA
    316cf8c View commit details
    Browse the repository at this point in the history
  2. Updated StatefulNavigationShell to only save the part of the RouteMat…

    …chList that relates to the current Navigator and below.
    
    Removed obsolete field subRoute from ShellRouteContext.
    tolo committed May 4, 2023
    Configuration menu
    Copy the full SHA
    79a0c63 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3696448 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Configuration menu
    Copy the full SHA
    763b136 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2f48831 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Apply suggestions from code review

    Review feedback
    
    Co-authored-by: chunhtai <[email protected]>
    tolo and chunhtai authored May 10, 2023
    Configuration menu
    Copy the full SHA
    709ee7a View commit details
    Browse the repository at this point in the history
  2. Implemented review feedback

    tolo committed May 10, 2023
    Configuration menu
    Copy the full SHA
    bb7fd9e View commit details
    Browse the repository at this point in the history
  3. Some additional cleanup

    tolo committed May 10, 2023
    Configuration menu
    Copy the full SHA
    9eaf1af View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    527a806 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Configuration menu
    Copy the full SHA
    86a72e1 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Apply suggestions from code review

    Co-authored-by: John Ryan <[email protected]>
    Co-authored-by: chunhtai <[email protected]>
    3 people authored May 18, 2023
    Configuration menu
    Copy the full SHA
    57b761f View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review.

    Minor additional cleanup.
    tolo committed May 18, 2023
    Configuration menu
    Copy the full SHA
    85fa0b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d75c5e2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bd1c018 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Configuration menu
    Copy the full SHA
    c13cd71 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c7b1295 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0f842ee View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    80c396f View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Configuration menu
    Copy the full SHA
    04b549a View commit details
    Browse the repository at this point in the history