-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_markdown] update markdown
dependency
#1395
[flutter_markdown] update markdown
dependency
#1395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the update breaks one of our test expectations.
Any ideas why Cirrus is showing tests as failing when the tests complete successfully on a local build? |
Have you tried deleting your lockfile to see if you have an older version of a transitive dependency that could be causing the difference? That's the first thing that comes to mind as a potential difference, since CI runs are always clean, so should always have the latest resolvable dependencies. |
Failure caused by change of behaviour in |
The tests should now turn green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.