Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_markdown] update markdown dependency #1395

Merged

Conversation

domesticmouse
Copy link
Contributor

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the update breaks one of our test expectations.

@domesticmouse
Copy link
Contributor Author

Any ideas why Cirrus is showing tests as failing when the tests complete successfully on a local build?

@stuartmorgan
Copy link
Contributor

Have you tried deleting your lockfile to see if you have an older version of a transitive dependency that could be causing the difference? That's the first thing that comes to mind as a potential difference, since CI runs are always clean, so should always have the latest resolvable dependencies.

@domesticmouse
Copy link
Contributor Author

Failure caused by change of behaviour in markdown package. Reported in dart-lang/tools#1300

@domesticmouse
Copy link
Contributor Author

The tests should now turn green.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domesticmouse domesticmouse merged commit 48cdaf6 into flutter:main Apr 16, 2022
@domesticmouse domesticmouse deleted the flutter_markdown-deps-update branch April 16, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants