Skip to content

Commit

Permalink
Merge branch 'main' into pr/replacement-mode
Browse files Browse the repository at this point in the history
  • Loading branch information
domesticmouse authored May 12, 2024
2 parents d60ba60 + 29dbf53 commit 6ce32f8
Show file tree
Hide file tree
Showing 73 changed files with 984 additions and 472 deletions.
83 changes: 0 additions & 83 deletions .ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,17 +394,13 @@ targets:
"CHANNEL": "stable"
}
# All of the Linux_android android_platform_tests shards have the same
# dependency list, despite some running on Android 33 AVDs versus 34.
# See https://github.com/flutter/flutter/issues/137082 for context.
- name: Linux_android android_platform_tests_shard_1 master
recipe: packages/packages
timeout: 60
properties:
target_file: android_platform_tests.yaml
channel: master
version_file: flutter_master.version
# set up for 34
package_sharding: "--shardIndex 0 --shardCount 6"
dependencies: >-
[
Expand All @@ -423,7 +419,6 @@ targets:
target_file: android_platform_tests.yaml
channel: master
version_file: flutter_master.version
# set up for 34
package_sharding: "--shardIndex 1 --shardCount 6"
dependencies: >-
[
Expand All @@ -442,7 +437,6 @@ targets:
target_file: android_platform_tests.yaml
channel: master
version_file: flutter_master.version
# set up for 34
package_sharding: "--shardIndex 2 --shardCount 6"
dependencies: >-
[
Expand All @@ -461,7 +455,6 @@ targets:
target_file: android_platform_tests.yaml
channel: master
version_file: flutter_master.version
# set up for 34
package_sharding: "--shardIndex 3 --shardCount 6"
dependencies: >-
[
Expand All @@ -480,7 +473,6 @@ targets:
target_file: android_platform_tests.yaml
channel: master
version_file: flutter_master.version
# set up for 34
package_sharding: "--shardIndex 4 --shardCount 6"
dependencies: >-
[
Expand All @@ -499,7 +491,6 @@ targets:
target_file: android_platform_tests.yaml
channel: master
version_file: flutter_master.version
# set up for 34
package_sharding: "--shardIndex 5 --shardCount 6"
dependencies: >-
[
Expand All @@ -511,44 +502,6 @@ targets:
"PACKAGE_SHARDING": "--shardIndex 5 --shardCount 6"
}
- name: Linux_android android_platform_tests_api_33_shard_1 master
recipe: packages/packages
timeout: 60
properties:
target_file: android_platform_tests_api_33_avd.yaml
channel: master
version_file: flutter_master.version
# set up for 33
package_sharding: "--shardIndex 0 --shardCount 2"
dependencies: >-
[
{"dependency": "android_virtual_device", "version": "android_33_google_apis_x64.textpb"}
]
env_variables: >-
{
"CHANNEL": "master",
"PACKAGE_SHARDING": "--shardIndex 0 --shardCount 2"
}
- name: Linux_android android_platform_tests_api_33_shard_2 master
recipe: packages/packages
timeout: 60
properties:
target_file: android_platform_tests_api_33_avd.yaml
channel: master
version_file: flutter_master.version
# set up for 33
package_sharding: "--shardIndex 1 --shardCount 2"
dependencies: >-
[
{"dependency": "android_virtual_device", "version": "android_33_google_apis_x64.textpb"}
]
env_variables: >-
{
"CHANNEL": "master",
"PACKAGE_SHARDING": "--shardIndex 1 --shardCount 2"
}
- name: Linux_android android_platform_tests_shard_1 stable
recipe: packages/packages
presubmit: false
Expand Down Expand Up @@ -663,42 +616,6 @@ targets:
"PACKAGE_SHARDING": "--shardIndex 5 --shardCount 6"
}
- name: Linux_android android_platform_tests_api_33_shard_1 stable
recipe: packages/packages
timeout: 60
properties:
target_file: android_platform_tests_api_33_avd.yaml
channel: stable
version_file: flutter_stable.version
package_sharding: "--shardIndex 0 --shardCount 2"
dependencies: >-
[
{"dependency": "android_virtual_device", "version": "android_33_google_apis_x64.textpb"}
]
env_variables: >-
{
"CHANNEL": "stable",
"PACKAGE_SHARDING": "--shardIndex 0 --shardCount 2"
}
- name: Linux_android android_platform_tests_api_33_shard_2 stable
recipe: packages/packages
timeout: 60
properties:
target_file: android_platform_tests_api_33_avd.yaml
channel: stable
version_file: flutter_stable.version
package_sharding: "--shardIndex 1 --shardCount 2"
dependencies: >-
[
{"dependency": "android_virtual_device", "version": "android_33_google_apis_x64.textpb"}
]
env_variables: >-
{
"CHANNEL": "stable",
"PACKAGE_SHARDING": "--shardIndex 1 --shardCount 2"
}
- name: Linux_android_legacy android_platform_tests_legacy_api_shard_1 master
recipe: packages/packages
timeout: 60
Expand Down
2 changes: 1 addition & 1 deletion .ci/flutter_master.version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
00f40667c16ae3f7cf0c567fe4a43c0a59046951
2aa05c16509b70db704cfd3e873cc8069723fa44
12 changes: 6 additions & 6 deletions .ci/targets/android_platform_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,23 @@ tasks:
- name: download Dart and Android deps
script: .ci/scripts/tool_runner.sh
infra_step: true
args: ["fetch-deps", "--android", "--supporting-target-platforms-only", "--exclude=script/configs/still_requires_api_33_avd.yaml"]
args: ["fetch-deps", "--android", "--supporting-target-platforms-only"]
- name: build examples
script: .ci/scripts/tool_runner.sh
args: ["build-examples", "--apk", "--exclude=script/configs/still_requires_api_33_avd.yaml"]
args: ["build-examples", "--apk"]
- name: lint
script: .ci/scripts/tool_runner.sh
args: ["lint-android", "--exclude=script/configs/still_requires_api_33_avd.yaml"]
args: ["lint-android"]
# Native unit and native integration are split into two steps to allow for
# different exclusions.
# TODO(stuartmorgan): Eliminate the native unit test exclusion, and combine
# these steps.
- name: native unit tests
script: .ci/scripts/tool_runner.sh
args: ["native-test", "--android", "--no-integration", "--exclude=script/configs/exclude_native_unit_android.yaml,script/configs/still_requires_api_33_avd.yaml"]
args: ["native-test", "--android", "--no-integration", "--exclude=script/configs/exclude_native_unit_android.yaml"]
- name: native integration tests
script: .ci/scripts/tool_runner.sh
args: ["native-test", "--android", "--no-unit", "--exclude=script/configs/still_requires_api_33_avd.yaml"]
args: ["native-test", "--android", "--no-unit"]
- name: drive examples
script: .ci/scripts/tool_runner.sh
args: ["drive-examples", "--android", "--exclude=script/configs/exclude_integration_android.yaml,script/configs/exclude_integration_android_emulator.yaml,script/configs/still_requires_api_33_avd.yaml"]
args: ["drive-examples", "--android", "--exclude=script/configs/exclude_integration_android.yaml,script/configs/exclude_integration_android_emulator.yaml"]
29 changes: 0 additions & 29 deletions .ci/targets/android_platform_tests_api_33_avd.yaml

This file was deleted.

3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,11 @@

pubspec.lock

# iOS and macOS dependencies
.build/
Podfile.lock
Pods/
.swiftpm/
.symlinks/

*instrumentscli*.trace
Expand Down
8 changes: 8 additions & 0 deletions packages/camera/camera_android_camerax/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
## 0.6.5

* Modifies `stopVideoRecording` to ensure that the method only returns when CameraX reports that the
recorded video finishes saving to a file.
* Modifies `startVideoCapturing` to ensure that the method only returns when CameraX reports that
video recording has started.
* Adds empty implementation for `setDescriptionWhileRecording` and leaves a todo to add this feature.

## 0.6.4+1

* Adds empty implementation for `prepareForVideoRecording` since this optimization is not used on Android.
Expand Down
13 changes: 5 additions & 8 deletions packages/camera/camera_android_camerax/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ use cases, the plugin behaves according to the following:
video recording and image streaming is supported, but concurrent video recording, image
streaming, and image capture is not supported.

### `setDescriptionWhileRecording` is unimplemented [Issue #148013][148013]
`setDescriptionWhileRecording`, used to switch cameras while recording video, is currently unimplemented
due to this not currently being supported by CameraX.

### 240p resolution configuration for video recording

240p resolution configuration for video recording is unsupported by CameraX,
Expand Down Expand Up @@ -64,11 +68,4 @@ For more information on contributing to this plugin, see [`CONTRIBUTING.md`](CON
[6]: https://developer.android.com/media/camera/camerax/architecture#combine-use-cases
[7]: https://developer.android.com/reference/android/hardware/camera2/CameraMetadata#INFO_SUPPORTED_HARDWARE_LEVEL_3
[8]: https://developer.android.com/reference/android/hardware/camera2/CameraMetadata#INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED
[120462]: https://github.com/flutter/flutter/issues/120462
[125915]: https://github.com/flutter/flutter/issues/125915
[120715]: https://github.com/flutter/flutter/issues/120715
[120468]: https://github.com/flutter/flutter/issues/120468
[120467]: https://github.com/flutter/flutter/issues/120467
[125371]: https://github.com/flutter/flutter/issues/125371
[126477]: https://github.com/flutter/flutter/issues/126477
[127896]: https://github.com/flutter/flutter/issues/127896
[148013]: https://github.com/flutter/flutter/issues/148013
Loading

0 comments on commit 6ce32f8

Please sign in to comment.