This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Fix crash, goldens, demo status bar icon color #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidezpl
changed the title
esouthren
approved these changes
Apr 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For 2.10.1 release:
Fix a common crash when opening a demo for the first time, caused by feature discovery.
shared_preferenceshad undesireable asynchronous behavior, so I replaced it withget_storage.I also wanted to fix the goldens test, but found the
Positionedwidget around the settings icon was unnecessarily adding padding, so removed it.SystemUiOverlayStyle.Tests
Tested manually
Issues
Fixes Firebase-detected crash