Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Add workflow for publishing MSIX package #929

Merged
merged 10 commits into from
Apr 21, 2023
Merged

Add workflow for publishing MSIX package #929

merged 10 commits into from
Apr 21, 2023

Conversation

yaakovschectman
Copy link
Contributor

Description

Add an example workflow for packaging an MSIX and publishing it to the Microsoft Store.

Adjacent to flutter/website#8539

@yaakovschectman yaakovschectman self-assigned this Apr 13, 2023
@yaakovschectman yaakovschectman mentioned this pull request Apr 13, 2023
Merged
3 tasks
guidezpl
guidezpl suggested changes Apr 14, 2023
View reviewed changes
.github/workflows/dart.yml Outdated Show resolved Hide resolved
loic-sharma
loic-sharma approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but please get approval from someone else who is more familiar with the gallery

guidezpl
guidezpl suggested changes Apr 20, 2023
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but could you add a blurb about this to the releasing instructions in the README, linking to the Windows store listing?

@yaakovschectman
Copy link
Contributor Author

@guidezpl What Windows store listing are you referring to?

@loic-sharma
Copy link
Member

@yaakovschectman I think the idea is to update the README's supported platforms section to link to Gallery app on the Microsoft Store and the releasing section to explain how to deploy the Gallery app to the Microsoft Store.

guidezpl
guidezpl approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

@guidezpl
Copy link
Member

You should be able to merge, right?

@yaakovschectman yaakovschectman merged commit 610003e into flutter:main Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guidezpl guidezpl guidezpl approved these changes

@loic-sharma loic-sharma loic-sharma approved these changes

@cbracken cbracken Awaiting requested review from cbracken

Assignees

@yaakovschectman yaakovschectman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaakovschectman @loic-sharma @guidezpl