This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
[Windows] Migrate runner to latest stable template #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
approved these changes
Jan 10, 2023
| } | ||
| FreeLibrary(user32_module); |
There was a problem hiding this comment.
I'm curious when user32_module would be non-null but enable_non_client_dpi_scaling would be null. I suppose if somehow we got a hold of a User32.dll that somehow didn't implement that function. Probably unlikely, but this is definitely the right change to make.
There was a problem hiding this comment.
Yup that's right. EnableNonClientDpiScaling was added in Windows 10, so I believe this affects Windows 7 and 8 users.
loic-sharma
added a commit
that referenced
this pull request
Jan 10, 2023
I incorrectly removed the Windows app icon in #860. Part of flutter/flutter#107926
Seven-112
pushed a commit
to Seven-112/gallery
that referenced
this pull request
May 16, 2023
I incorrectly removed the Windows app icon in flutter/gallery#860. Part of flutter/flutter#107926
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm preparing docs on how to migrate an existing Windows app to support dark title bars. These docs will use the Flutter Gallery as an example.
This change migrates the Windows runner to the latest stable template (dark title bar support is only in the master channel currently). This prepares the Flutter Gallery for the dark title bar migration, which will be done in separate pull request.
Part of flutter/flutter#107926
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.