Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

[ProgressIndicator Demo]Added label for progress indicator without percentage value #840

Merged
merged 1 commit into from
Dec 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions lib/codeviewer/code_segments.dart
Original file line number Diff line number Diff line change
Expand Up @@ -35607,10 +35607,23 @@ class CodeSegments {
TextSpan(style: codeStyle.baseStyle, text: ' '),
TextSpan(style: codeStyle.punctuationStyle, text: '['),
TextSpan(style: codeStyle.baseStyle, text: '\u000a '),
TextSpan(style: codeStyle.keywordStyle, text: 'const'),
TextSpan(style: codeStyle.baseStyle, text: ' '),
TextSpan(style: codeStyle.classStyle, text: 'CircularProgressIndicator'),
TextSpan(style: codeStyle.punctuationStyle, text: '(),'),
TextSpan(style: codeStyle.punctuationStyle, text: '('),
TextSpan(
style: codeStyle.baseStyle,
text: '\u000a semanticsLabel'),
TextSpan(style: codeStyle.punctuationStyle, text: ':'),
TextSpan(style: codeStyle.baseStyle, text: ' '),
TextSpan(style: codeStyle.classStyle, text: 'GalleryLocalizations'),
TextSpan(style: codeStyle.punctuationStyle, text: '.'),
TextSpan(style: codeStyle.baseStyle, text: 'of'),
TextSpan(style: codeStyle.punctuationStyle, text: '('),
TextSpan(style: codeStyle.baseStyle, text: 'context'),
TextSpan(style: codeStyle.punctuationStyle, text: ')!.'),
TextSpan(style: codeStyle.baseStyle, text: 'loading'),
TextSpan(style: codeStyle.punctuationStyle, text: ','),
TextSpan(style: codeStyle.baseStyle, text: '\u000a '),
TextSpan(style: codeStyle.punctuationStyle, text: '),'),
TextSpan(style: codeStyle.baseStyle, text: '\u000a '),
TextSpan(style: codeStyle.keywordStyle, text: 'const'),
TextSpan(style: codeStyle.baseStyle, text: ' '),
Expand Down
4 changes: 3 additions & 1 deletion lib/demos/material/progress_indicator_demo.dart
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ class _ProgressIndicatorDemoState extends State<ProgressIndicatorDemo>
case ProgressIndicatorDemoType.circular:
return Column(
children: [
const CircularProgressIndicator(),
CircularProgressIndicator(
semanticsLabel: GalleryLocalizations.of(context)!.loading,
),
const SizedBox(height: 32),
CircularProgressIndicator(value: _animation.value),
],
Expand Down
4 changes: 4 additions & 0 deletions lib/l10n/intl_en.arb
Original file line number Diff line number Diff line change
Expand Up @@ -2234,6 +2234,10 @@
"@demo": {
"description": "Used in the title of the demos."
},
"loading": "Loading",
"@loading": {
"description": "Indicates the loading process."
},
"dialogDiscardTitle": "Discard draft?",
"@dialogDiscardTitle": {
"description": "Alert dialog message to discard draft."
Expand Down
4 changes: 4 additions & 0 deletions lib/l10n/intl_en_US.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2101,6 +2101,10 @@
name="demo"
description="Used in the title of the demos."
>Demo</string>
<string
name="loading"
description="Indicates the loading process."
>Loading</string>
<string
name="dialogDiscardTitle"
description="Alert dialog message to discard draft."
Expand Down