Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Remove unnecessary ! operator. #822

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Remove unnecessary ! operator. #822

merged 1 commit into from
Nov 2, 2022

Conversation

asashour
Copy link
Contributor

@asashour asashour commented Nov 2, 2022

These cause failure on the SDK build, with a log of:

warning - test_benchmarks/benchmarks/scroll.dart:88:66 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - test_benchmarks/benchmarks/scroll.dart:98:34 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - test_benchmarks/benchmarks/scroll.dart:104:21 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bwilkerson
Copy link

Note: These diagnostics are breaking the Dart SDK's flutter-analyze bot, which we depend on to tell us when changes to the analyzer will break the roll of the Dart SDK into flutter.

@guidezpl guidezpl merged commit a9738d3 into flutter:main Nov 2, 2022
@asashour asashour deleted the bang branch November 2, 2022 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants