This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Fix new syntax for escaping with single quotes #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like some existing tests are failing |
guidezpl
approved these changes
Oct 6, 2022
thkim1011
added a commit
that referenced
this pull request
Oct 13, 2022
This reverts commit b330ebf.
guidezpl
pushed a commit
that referenced
this pull request
Oct 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're adding a new syntax to support escaping in ICU MessageFormat via single quotes. According to official documentation, the behavior is that any characters within single quotes will not be parsed and to use the single quote character in a string, you need to use a pair of consecutive single quotes. See here.
The only changes in this PR is
'to''.{per cent}to{percent}in some English translation, since the former is not valid syntax.I checked that
flutter gen-l10nruns when using the branch in the PR below.Related PR: flutter/flutter#112390.