This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Enable scrollbars #735
Merged
Enable scrollbars #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
reviewed
Jul 12, 2022
| // the gallery need to be audited before enabling this feature, | ||
| // see https://github.com/flutter/gallery/issues/523 | ||
| scrollBehavior: | ||
| const MaterialScrollBehavior().copyWith(scrollbars: false), |
There was a problem hiding this comment.
I think the error presented itself in other demo apps in the gallery as well. We recently changed the default PrimaryScrollController behavior (flutter/flutter#102099) to better avoid that error in general, so it may be ok.
I think the Shrine app was one that also had this issue.
There was a problem hiding this comment.
Ah I see. Can't repro on Shrine anymore.
|
There are integration tests that open all the demos. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #523
I can't repro the original issue, but out of caution, I've set
primary: falseon the secondary scrollable on the home screen.