-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
c450edb
to
f0eeed3
Compare
lib/codeviewer/code_segments.dart
Outdated
TextSpan(style: codeStyle.stringStyle, text: '\u0027dart:ui\u0027'), | ||
TextSpan(style: codeStyle.baseStyle, text: ' show '), | ||
TextSpan(style: codeStyle.classStyle, text: 'Vertices'), | ||
TextSpan( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are being generated in a version before this change as well (after updating code-segments) :
TextSpan(
style: codeStyle.stringStyle,
text: '\u0027package:flutter/material.dart\u0027'),
TextSpan(style: codeStyle.punctuationStyle, text: ';'),
TextSpan(style: codeStyle.baseStyle, text: '\u000a'),
TextSpan(style: codeStyle.keywordStyle, text: 'import'),
TextSpan(style: codeStyle.baseStyle, text: ' '),
TextSpan(
style: codeStyle.stringStyle,
text:
'\u0027package:flutter_gen/gen_l10n/gallery_localizations.dart\u0027'),
TextSpan(style: codeStyle.punctuationStyle, text: ';'),
TextSpan(style: codeStyle.baseStyle, text: '\u000a\u000a'),
which should not be there IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find the issue, but for some unknown reason, the code viewer generates differently on non-Unix platforms. Can you revert the changes to the the updated code? I can add those
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, will revert the code-segments changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guidezpl can you review and add these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_ ___ _____ __ __
| | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|
Migrates tool/ & gallery options to null safety.
part of #527
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.