Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Run verifications on all platforms #565

Merged
merged 11 commits into from
Dec 10, 2021
Merged

Run verifications on all platforms #565

merged 11 commits into from
Dec 10, 2021

Conversation

guidezpl
Copy link
Member

@guidezpl guidezpl commented Dec 9, 2021

Closes #37

There were a few issues underlying l10n. This PR refactors the cli, converts flutter pub grinder verify-l10n to a test, corrects apostrophes.

This PR refactors the code segments script, makes formatting part of it, and converts flutter pub grinder verify-code-segments to a test.

- name: Ensure the Dart code is formatted correctly
run: flutter format --set-exit-if-changed --dry-run .
- name: Run Flutter unit tests
run: flutter test
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only change is here, the rest is automatic formatting

Copy link
Contributor

@rami-a rami-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guidezpl guidezpl merged commit ec04522 into master Dec 10, 2021
@guidezpl guidezpl deleted the guidezpl-patch-3 branch December 10, 2021 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code segment generator will get different imports on unix and macOS, verify-l10n is different on windows
2 participants