Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Temporarily remove shared_preferences dependency until it can be used with nnbd #385

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Temporarily remove shared_preferences dependency until it can be used with nnbd #385

merged 2 commits into from
Dec 8, 2020

Conversation

rami-a
Copy link
Contributor

@rami-a rami-a commented Dec 8, 2020

This is to unblock the NNBD migration for flutter

JoseAlba
JoseAlba approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@JoseAlba JoseAlba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

██╗      ██████╗ ████████╗███╗   ███╗
██║     ██╔════╝ ╚══██╔══╝████╗ ████║
██║     ██║  ███╗   ██║   ██╔████╔██║
██║     ██║   ██║   ██║   ██║╚██╔╝██║
███████╗╚██████╔╝   ██║   ██║ ╚═╝ ██║
╚══════╝ ╚═════╝    ╚═╝   ╚═╝     ╚═╝

lib/pages/demo.dart Outdated Show resolved Hide resolved
guidezpl
guidezpl approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

@rami-a rami-a merged commit 9dd9e78 into flutter:master Dec 8, 2020
@rami-a rami-a deleted the remove-shared-pref branch December 8, 2020 19:09
@guidezpl guidezpl mentioned this pull request Dec 9, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoseAlba JoseAlba JoseAlba approved these changes

@guidezpl guidezpl guidezpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rami-a @guidezpl @JoseAlba