Added label for progress indicator without percentage value (#840)

flutter · Dec 8, 2022 · d8ac3e2 · d8ac3e2
1 parent d67a02e
commit d8ac3e2
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 4 deletions.
diff --git a/lib/codeviewer/code_segments.dart b/lib/codeviewer/code_segments.dart
@@ -35607,10 +35607,23 @@ class CodeSegments {
       TextSpan(style: codeStyle.baseStyle, text: ' '),
       TextSpan(style: codeStyle.punctuationStyle, text: '['),
       TextSpan(style: codeStyle.baseStyle, text: '\u000a            '),
-      TextSpan(style: codeStyle.keywordStyle, text: 'const'),
-      TextSpan(style: codeStyle.baseStyle, text: ' '),
       TextSpan(style: codeStyle.classStyle, text: 'CircularProgressIndicator'),
-      TextSpan(style: codeStyle.punctuationStyle, text: '(),'),
+      TextSpan(style: codeStyle.punctuationStyle, text: '('),
+      TextSpan(
+          style: codeStyle.baseStyle,
+          text: '\u000a              semanticsLabel'),
+      TextSpan(style: codeStyle.punctuationStyle, text: ':'),
+      TextSpan(style: codeStyle.baseStyle, text: ' '),
+      TextSpan(style: codeStyle.classStyle, text: 'GalleryLocalizations'),
+      TextSpan(style: codeStyle.punctuationStyle, text: '.'),
+      TextSpan(style: codeStyle.baseStyle, text: 'of'),
+      TextSpan(style: codeStyle.punctuationStyle, text: '('),
+      TextSpan(style: codeStyle.baseStyle, text: 'context'),
+      TextSpan(style: codeStyle.punctuationStyle, text: ')!.'),
+      TextSpan(style: codeStyle.baseStyle, text: 'loading'),
+      TextSpan(style: codeStyle.punctuationStyle, text: ','),
+      TextSpan(style: codeStyle.baseStyle, text: '\u000a            '),
+      TextSpan(style: codeStyle.punctuationStyle, text: '),'),
       TextSpan(style: codeStyle.baseStyle, text: '\u000a            '),
       TextSpan(style: codeStyle.keywordStyle, text: 'const'),
       TextSpan(style: codeStyle.baseStyle, text: ' '),

diff --git a/lib/demos/material/progress_indicator_demo.dart b/lib/demos/material/progress_indicator_demo.dart
@@ -66,7 +66,9 @@ class _ProgressIndicatorDemoState extends State<ProgressIndicatorDemo>
       case ProgressIndicatorDemoType.circular:
         return Column(
           children: [
-            const CircularProgressIndicator(),
+            CircularProgressIndicator(
+              semanticsLabel: GalleryLocalizations.of(context)!.loading,
+            ),
             const SizedBox(height: 32),
             CircularProgressIndicator(value: _animation.value),
           ],

diff --git a/lib/l10n/intl_en.arb b/lib/l10n/intl_en.arb
@@ -2234,6 +2234,10 @@
   "@demo": {
     "description": "Used in the title of the demos."
   },
+  "loading": "Loading",
+  "@loading": {
+    "description": "Indicates the loading process."
+  },
   "dialogDiscardTitle": "Discard draft?",
   "@dialogDiscardTitle": {
     "description": "Alert dialog message to discard draft."

diff --git a/lib/l10n/intl_en_US.xml b/lib/l10n/intl_en_US.xml
@@ -2101,6 +2101,10 @@
     name="demo"
     description="Used in the title of the demos."
     >Demo</string>
+  <string
+    name="loading"
+    description="Indicates the loading process."
+    >Loading</string>
   <string
     name="dialogDiscardTitle"
     description="Alert dialog message to discard draft."