-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make scrollbar assertions less aggressive #84809
Conversation
I like the proposed changes. Delaying the assertion to when the scrollbar has been interacted with, will help a lot to tell which scrollbar in the tree is incorrect. The error in the gallery project was a bit confusing. |
This should only delay it until it is visible and available for interaction. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the example, really helpful
Lgtm
This pull request is not suitable for automatic merging in its current state.
|
This adjusts the assertions on interactive scrollbars to only be applied when the scrollbar is visible.
Related issues:
This also adds more documentation and code samples. I cleaned up a bit, removing outstanding todos and fixing some abbreviations in the tests.
For some of the removed todos, I filed issues to actually track the feature requests. 🙃
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.