Android log reader reads any recent logs #45743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
tool
Hixie
reviewed
Nov 28, 2019
| ProcessManager: () => mockProcessManager, | ||
| }); | ||
| }); | ||
|
|
||
| test('Can parse adb shell dumpsys info', () { |
There was a problem hiding this comment.
we should probably also have a real devicelab test that verifies that we're not getting old logs when you run flutter run or flutter logs
|
|
Hixie
reviewed
Nov 28, 2019
| final List<String> args = <String>['shell', '-x', 'logcat', '-v', 'time', '-s', 'flutter']; | ||
| final String lastTimestamp = device.lastLogcatTimestamp; | ||
| // Start the adb logcat process and filter the most recent logs since `lastTimestamp`. | ||
| final List<String> args = <String>['logcat', '-v', 'time', '-T', lastTimestamp]; | ||
| processUtils.start(device.adbCommandForDevice(args)).then<void>((Process process) { |
There was a problem hiding this comment.
this looks a lot simpler than the code used to look; why was the old code more complicated?
There was a problem hiding this comment.
I'm not sure. I was trying to see in which version the -T flag was introduced.
|
Approach sounds reasonable to me. |
This was referenced Feb 10, 2020
Closed
This was referenced Mar 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #45307, the Android log reader doesn't filter older logs. Instead, it filters by tag and the protocol discovery class throttles the logs to discover the most recent observatory URI. The intention with this change was to allow
flutter attachto attach to an app already running on the device. However, this implementation detail is used by the microbenchmarks test to extract the benchmark data.This PR reverts to the old behavior. Going forward, we can have two factories for the Android log reader such the one that filters by tags is explicitly injected in the
flutter attachflow and the other one is injected influtter run/logsflows. cc @xsterRelated Issues
Fixes #45732
Tests
I added the following tests: Unit test
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?