Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for image.error_builder.0.dart API example. #148497

Merged
merged 2 commits into from
May 20, 2024
Merged

Add test for image.error_builder.0.dart API example. #148497

merged 2 commits into from
May 20, 2024

Conversation

ksokolovskyi
Copy link
Contributor

This PR contributes to #130459

Description

  • Adds tests for examples/api/lib/widgets/image/image.error_builder.0.dart

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels May 16, 2024
@goderbauer goderbauer requested review from bleroux and TahaTesser May 17, 2024 21:04
TahaTesser
TahaTesser approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ksokolovskyi ksokolovskyi force-pushed the add-image-error-builder-example-tests branch from a18e69a to 6a52c74 Compare May 20, 2024 10:00
bleroux
bleroux approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(Just one small nit to fix)

examples/api/test/widgets/image/image.error_builder.0_test.dart Outdated
HttpOverrides.global = null;
});

testWidgets('has nonexistent url', (WidgetTester tester) async {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
testWidgets('has nonexistent url', (WidgetTester tester) async {
testWidgets('Has nonexistent url', (WidgetTester tester) async {

@ksokolovskyi ksokolovskyi force-pushed the add-image-error-builder-example-tests branch from 6a52c74 to 52c726a Compare May 20, 2024 14:51
@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024
@auto-submit auto-submit bot merged commit 02a6c91 into flutter:master May 20, 2024
139 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 20, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2024
@engine-flutter-autoroll
02a6c91 Add test for image.error_builder.0.dart API example. (flutter…
55e358e 
…/flutter#148497)
@ksokolovskyi
Copy link
Contributor Author

@TahaTesser @bleroux thanks a lot for the review!

auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 20, 2024
@engine-flutter-autoroll
Roll Flutter from adf279f to 02a6c91 (8 revisions) (#6776)
8137353 
flutter/flutter@adf279f...02a6c91

2024-05-20 [email protected] Add test for image.error_builder.0.dart API example. (flutter/flutter#148497)
2024-05-20 [email protected] Roll Packages from ae4dd32 to ba19b24 (3 revisions) (flutter/flutter#148679)
2024-05-20 [email protected] Add test for tab_controller.1.dart API example. (flutter/flutter#148189)
2024-05-20 [email protected] Add test for fade_transition.0.dart API example. (flutter/flutter#148178)
2024-05-20 [email protected] Add tests for scaffold.of.#.dart API examples. (flutter/flutter#147637)
2024-05-20 [email protected] Roll Flutter Engine from 9d00f77f243f to c6fecf65fbf3 (1 revision) (flutter/flutter#148654)
2024-05-20 [email protected] Roll Flutter Engine from 426dbb125861 to 9d00f77f243f (1 revision) (flutter/flutter#148652)
2024-05-19 [email protected] Roll Flutter Engine from 552a965b707b to 426dbb125861 (2 revisions) (flutter/flutter#148630)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@engine-flutter-autoroll @TecHaxter
Roll Flutter from adf279f to 02a6c91 (8 revisions) (flutter#6776)
cc18b86 
flutter/flutter@adf279f...02a6c91

2024-05-20 [email protected] Add test for image.error_builder.0.dart API example. (flutter/flutter#148497)
2024-05-20 [email protected] Roll Packages from ae4dd32 to ba19b24 (3 revisions) (flutter/flutter#148679)
2024-05-20 [email protected] Add test for tab_controller.1.dart API example. (flutter/flutter#148189)
2024-05-20 [email protected] Add test for fade_transition.0.dart API example. (flutter/flutter#148178)
2024-05-20 [email protected] Add tests for scaffold.of.#.dart API examples. (flutter/flutter#147637)
2024-05-20 [email protected] Roll Flutter Engine from 9d00f77f243f to c6fecf65fbf3 (1 revision) (flutter/flutter#148654)
2024-05-20 [email protected] Roll Flutter Engine from 426dbb125861 to 9d00f77f243f (1 revision) (flutter/flutter#148652)
2024-05-19 [email protected] Roll Flutter Engine from 552a965b707b to 426dbb125861 (2 revisions) (flutter/flutter#148630)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@Piinks Piinks mentioned this pull request May 31, 2024
Open
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @arc-yong
Roll Flutter from adf279f to 02a6c91 (8 revisions) (flutter#6776)
cc110d8 
flutter/flutter@adf279f...02a6c91

2024-05-20 [email protected] Add test for image.error_builder.0.dart API example. (flutter/flutter#148497)
2024-05-20 [email protected] Roll Packages from ae4dd32 to ba19b24 (3 revisions) (flutter/flutter#148679)
2024-05-20 [email protected] Add test for tab_controller.1.dart API example. (flutter/flutter#148189)
2024-05-20 [email protected] Add test for fade_transition.0.dart API example. (flutter/flutter#148178)
2024-05-20 [email protected] Add tests for scaffold.of.#.dart API examples. (flutter/flutter#147637)
2024-05-20 [email protected] Roll Flutter Engine from 9d00f77f243f to c6fecf65fbf3 (1 revision) (flutter/flutter#148654)
2024-05-20 [email protected] Roll Flutter Engine from 426dbb125861 to 9d00f77f243f (1 revision) (flutter/flutter#148652)
2024-05-19 [email protected] Roll Flutter Engine from 552a965b707b to 426dbb125861 (2 revisions) (flutter/flutter#148630)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
02a6c91 Add test for image.error_builder.0.dart API example. (flutter…
8df7297 
…/flutter#148497)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TahaTesser TahaTesser TahaTesser approved these changes

@bleroux bleroux bleroux approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ksokolovskyi @bleroux @TahaTesser