Added missing tests for Table api example `table.0.dart`. #147318

kishan-dhankecha · 2024-04-24T17:05:38Z

Added missing tests for Table example. Issue #130459

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

kishan-dhankecha · 2024-04-25T03:45:29Z

I watched your video for contribution and I am stuck here. I opened a pull request with the same changes and process as you but still, some tests of CI/CD are failing here. What should we do next? Do we tag someone who can review this?

matthew-carroll · 2024-04-25T04:53:24Z

@TahaTesser are you able to help guide this PR? Please see the message above.

TahaTesser

Thanks for the contribution! Overall good job, we can improvement this test a bit.

examples/api/test/widgets/table/table.0_test.dart

kishan-dhankecha · 2024-04-25T16:27:28Z

Did I get this right? @TahaTesser

I mean first I pulled my branch from the origin (not upstream master, branch for this PR) and after that, I made suggested changes, Committed those changes, and Pushed.

TahaTesser

LGTM with minor fixes

examples/api/test/widgets/table/table.0_test.dart

bleroux

LGTM! Thanks for your contribution.

auto-submit · 2024-04-26T08:31:28Z

auto label is removed for flutter/flutter/147318, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

kishan-dhankecha · 2024-04-26T12:45:01Z

@bleroux @TahaTesser What did go wrong here? Is it again a commit tree-related issue?

I have checked the details for Google testing but I did not get any meaningful explanation.

bleroux · 2024-04-26T13:07:04Z

What did go wrong here? Is it again a commit tree-related issue?

Probably nothing wrong with your PR.
I rebased it, this will run all tests again, let see how it goes. 🤞

kishan-dhankecha · 2024-04-26T14:31:32Z

@bleroux Still the same. This time check failed earlier than the last check.

bleroux · 2024-04-26T14:37:18Z

It happens sometimes, we will have to wait and rebase again, probably on Monday.

christopherfujino · 2024-04-26T20:00:05Z

Looked at the Google testing failures on cl/628384130, but they seem unrelated.

christopherfujino · 2024-04-26T21:30:21Z

I manually overrode it and added autosubmit

…utter/flutter#147318)

flutter/flutter@2e80670...f9933b6 2024-04-27 [email protected] Roll Flutter Engine from 5205e3683a0a to 20fb62ba1455 (1 revision) (flutter/flutter#147449) 2024-04-27 [email protected] Roll Flutter Engine from e14649ea0c80 to 5205e3683a0a (1 revision) (flutter/flutter#147448) 2024-04-27 [email protected] Roll Flutter Engine from 87f489c1bed4 to e14649ea0c80 (1 revision) (flutter/flutter#147446) 2024-04-27 [email protected] Roll Flutter Engine from cecf5aa8a778 to 87f489c1bed4 (1 revision) (flutter/flutter#147445) 2024-04-27 [email protected] Roll Flutter Engine from 8af10eba3ef3 to cecf5aa8a778 (1 revision) (flutter/flutter#147444) 2024-04-27 [email protected] [macOS] Eliminate flutter_gallery_macos__start_up benchmark (flutter/flutter#147442) 2024-04-27 [email protected] Roll Flutter Engine from bc055398f42a to 8af10eba3ef3 (1 revision) (flutter/flutter#147441) 2024-04-27 [email protected] Roll Flutter Engine from c410180e5bba to bc055398f42a (7 revisions) (flutter/flutter#147440) 2024-04-26 [email protected] Add tests for character_activator.0.dart API example. (flutter/flutter#147384) 2024-04-26 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.2 to 3.25.3 (flutter/flutter#147437) 2024-04-26 [email protected] Add integration test for asset transformation feature (flutter/flutter#145715) 2024-04-26 [email protected] Added missing tests for Table api example `table.0.dart`. (flutter/flutter#147318) 2024-04-26 [email protected] Catch any `FileSystemException` thrown when trying to read the template manifest during `flutter create` (flutter/flutter#145620) 2024-04-26 [email protected] fixes `CupertinoFullscreenDialogTransition` leaks (flutter/flutter#147168) 2024-04-26 [email protected] Fix helperMaxLines and errorMaxLines documentation (flutter/flutter#147409) 2024-04-26 [email protected] Refactor route focus node creation (flutter/flutter#147390) 2024-04-26 [email protected] Roll Packages from fde908d to dd01140 (5 revisions) (flutter/flutter#147420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…utter/flutter#147318)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Apr 24, 2024

TahaTesser force-pushed the 130459_test-added-for-table-api-example branch from 3b21bad to 931ebc3 Compare April 25, 2024 11:51

TahaTesser requested changes Apr 25, 2024

View reviewed changes

kishan-dhankecha requested a review from TahaTesser April 26, 2024 07:15

TahaTesser approved these changes Apr 26, 2024

View reviewed changes

examples/api/test/widgets/table/table.0_test.dart Outdated Show resolved Hide resolved

examples/api/test/widgets/table/table.0_test.dart Outdated Show resolved Hide resolved

TahaTesser requested a review from bleroux April 26, 2024 07:26

bleroux approved these changes Apr 26, 2024

View reviewed changes

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 26, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 26, 2024

kishan-dhankecha and others added 4 commits April 26, 2024 15:04

Added missing tests for Table api example.

a83ab26

Refactor table api test for clarity

8469af7

Update examples/api/test/widgets/table/table.0_test.dart

698a227

Update examples/api/test/widgets/table/table.0_test.dart

1088b93

bleroux force-pushed the 130459_test-added-for-table-api-example branch from af19100 to 1088b93 Compare April 26, 2024 13:04

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 26, 2024

auto-submit bot merged commit e4ad159 into flutter:master Apr 26, 2024
138 checks passed

kishan-dhankecha deleted the 130459_test-added-for-table-api-example branch April 27, 2024 02:43

kishan-dhankecha restored the 130459_test-added-for-table-api-example branch April 27, 2024 02:48

kishan-dhankecha deleted the 130459_test-added-for-table-api-example branch April 27, 2024 02:49

engine-flutter-autoroll mentioned this pull request Apr 27, 2024

Roll Flutter from 2e806700b928 to f9933b6994e4 (17 revisions) flutter/packages#6619

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2024

e4ad159 Added missing tests for Table api example table.0.dart. (fl…

74c8d89

…utter/flutter#147318)

engine-flutter-autoroll mentioned this pull request Apr 27, 2024

Roll Flutter from 2e806700b928 to f9933b6994e4 (17 revisions) flutter/packages#6620

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2024

e4ad159 Added missing tests for Table api example table.0.dart. (fl…

1cacb81

…utter/flutter#147318)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

e4ad159 Added missing tests for Table api example table.0.dart. (fl…

acead3e

…utter/flutter#147318)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added missing tests for Table api example `table.0.dart`. #147318

Added missing tests for Table api example `table.0.dart`. #147318

kishan-dhankecha commented Apr 24, 2024

kishan-dhankecha commented Apr 25, 2024

matthew-carroll commented Apr 25, 2024

TahaTesser left a comment •

edited

Loading

kishan-dhankecha commented Apr 25, 2024

TahaTesser left a comment

bleroux left a comment

auto-submit bot commented Apr 26, 2024

kishan-dhankecha commented Apr 26, 2024

bleroux commented Apr 26, 2024

kishan-dhankecha commented Apr 26, 2024

bleroux commented Apr 26, 2024

christopherfujino commented Apr 26, 2024

christopherfujino commented Apr 26, 2024

Added missing tests for Table api example table.0.dart. #147318

Added missing tests for Table api example table.0.dart. #147318

Conversation

kishan-dhankecha commented Apr 24, 2024

Pre-launch Checklist

kishan-dhankecha commented Apr 25, 2024

matthew-carroll commented Apr 25, 2024

TahaTesser left a comment • edited Loading

Choose a reason for hiding this comment

kishan-dhankecha commented Apr 25, 2024

TahaTesser left a comment

Choose a reason for hiding this comment

bleroux left a comment

Choose a reason for hiding this comment

auto-submit bot commented Apr 26, 2024

kishan-dhankecha commented Apr 26, 2024

bleroux commented Apr 26, 2024

kishan-dhankecha commented Apr 26, 2024

bleroux commented Apr 26, 2024

christopherfujino commented Apr 26, 2024

christopherfujino commented Apr 26, 2024

Added missing tests for Table api example `table.0.dart`. #147318

Added missing tests for Table api example `table.0.dart`. #147318

TahaTesser left a comment •

edited

Loading