Add test for animated_positioned.0.dart API example. #146720

ksokolovskyi · 2024-04-13T12:53:50Z

This PR contributes to #130459

Description

Adds examples/api/test/widgets/implicit_animations/animated_positioned.0_test.dart test

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

Renzo-Olivares

LGTM

justinmc

LGTM with nits 👍

examples/api/test/widgets/implicit_animations/animated_positioned.0_test.dart

ksokolovskyi · 2024-04-20T12:57:12Z

@justinmc @Renzo-Olivares thanks for the review!
I applied suggestions in the latest commit.

Renzo-Olivares

LGTM

ksokolovskyi · 2024-04-23T17:26:12Z

@Renzo-Olivares @justinmc thanks for the review!

…/flutter#146720)

flutter/flutter@77043ba...dba4f77 2024-04-24 [email protected] Fix memory leaks in `BottomNavigationBar` (flutter/flutter#147213) 2024-04-24 [email protected] Disable leak tracking for selection text area (flutter/flutter#147273) 2024-04-24 [email protected] Add missing `overlayColor` property in `styleFrom` methods (flutter/flutter#146685) 2024-04-24 [email protected] Roll Flutter Engine from 3d91141e7e18 to b5d5832f7144 (1 revision) (flutter/flutter#147293) 2024-04-24 [email protected] Roll Flutter Engine from d4f63383d329 to 3d91141e7e18 (1 revision) (flutter/flutter#147281) 2024-04-24 [email protected] Roll Flutter Engine from fcb106011371 to d4f63383d329 (1 revision) (flutter/flutter#147276) 2024-04-24 [email protected] Roll Flutter Engine from 7f89b4367338 to fcb106011371 (1 revision) (flutter/flutter#147272) 2024-04-24 [email protected] Roll Flutter Engine from 9819627013f7 to 7f89b4367338 (2 revisions) (flutter/flutter#147270) 2024-04-24 [email protected] Roll Flutter Engine from d56a231cddc2 to 9819627013f7 (3 revisions) (flutter/flutter#147267) 2024-04-23 [email protected] Roll Flutter Engine from 5f17a779f19d to d56a231cddc2 (1 revision) (flutter/flutter#147266) 2024-04-23 [email protected] Roll Flutter Engine from 303e71890897 to 5f17a779f19d (1 revision) (flutter/flutter#147264) 2024-04-23 [email protected] Remove unneeded local variables and comments in Editable and RenderParagraph (flutter/flutter#146843) 2024-04-23 [email protected] Add test for sliver_animated_opacity.0.dart API example. (flutter/flutter#146722) 2024-04-23 [email protected] Adds AutovalidateMode.onFocusChange to Form and FormField (flutter/flutter#140962) 2024-04-23 [email protected] Roll Flutter Engine from b686508a1dbf to 303e71890897 (4 revisions) (flutter/flutter#147262) 2024-04-23 [email protected] Roll Flutter Engine from f23cc4dda1ad to b686508a1dbf (4 revisions) (flutter/flutter#147258) 2024-04-23 [email protected] Add test for focus_node.0.dart API example. (flutter/flutter#146943) 2024-04-23 [email protected] Roll Flutter Engine from 066953b74042 to f23cc4dda1ad (3 revisions) (flutter/flutter#147255) 2024-04-23 [email protected] Refactor framework + test harness tests (flutter/flutter#146213) 2024-04-23 [email protected] Fix chips delete icon override the default icon size and ignores `IconTheme` from the chip property and `ChipThemeData` (flutter/flutter#146509) 2024-04-23 [email protected] Roll Flutter Engine from f794e6719d3c to 066953b74042 (3 revisions) (flutter/flutter#147248) 2024-04-23 [email protected] Fix frozen `StretchingOverscrollIndicator` animation (flutter/flutter#147195) 2024-04-23 [email protected] Add test for animated_align.0.dart API example. (flutter/flutter#146719) 2024-04-23 [email protected] Fix typos related to Navigator (flutter/flutter#147221) 2024-04-23 [email protected] Fix memory leak in switch painter (flutter/flutter#147228) 2024-04-23 [email protected] Add test for animated_positioned.0.dart API example. (flutter/flutter#146720) 2024-04-23 [email protected] Update icon tree shaker to allow system font fallback (flutter/flutter#147202) 2024-04-23 [email protected] `flutter/lib/src/`: refactoring if-chains into switch expressions (flutter/flutter#146293) 2024-04-23 [email protected] Roll Flutter Engine from 79f49954cce8 to f794e6719d3c (1 revision) (flutter/flutter#147241) 2024-04-23 [email protected] Roll Packages from 01a32c4 to cf6d280 (5 revisions) (flutter/flutter#147240) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…/flutter#146720)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Apr 13, 2024

Renzo-Olivares approved these changes Apr 17, 2024

View reviewed changes

ksokolovskyi force-pushed the add-animated-positioned-example-tests branch from 5f3fcea to 2915867 Compare April 19, 2024 15:44

Add test for animated_positioned.0.dart API example.

0537c6a

ksokolovskyi force-pushed the add-animated-positioned-example-tests branch from 2915867 to 0537c6a Compare April 19, 2024 16:37

Merge branch 'master' into add-animated-positioned-example-tests

87191fb

justinmc approved these changes Apr 19, 2024

View reviewed changes

examples/api/test/widgets/implicit_animations/animated_positioned.0_test.dart Outdated Show resolved Hide resolved

ksokolovskyi added 2 commits April 20, 2024 13:56

Merge branch 'master' into add-animated-positioned-example-tests

7e8e8a0

Apply review suggestions.

3197439

ksokolovskyi requested a review from Renzo-Olivares April 22, 2024 21:14

Renzo-Olivares approved these changes Apr 23, 2024

View reviewed changes

Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 23, 2024

auto-submit bot merged commit b0524b3 into flutter:master Apr 23, 2024
140 checks passed

engine-flutter-autoroll mentioned this pull request Apr 24, 2024

Roll Flutter from 77043bae1a5e to fa85f69e47d8 (28 revisions) flutter/packages#6604

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2024

b0524b3 Add test for animated_positioned.0.dart API example. (flutter…

4a19869

…/flutter#146720)

engine-flutter-autoroll mentioned this pull request Apr 24, 2024

Roll Flutter from 77043bae1a5e to 2676c84a90d2 (29 revisions) flutter/packages#6606

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2024

b0524b3 Add test for animated_positioned.0.dart API example. (flutter…

2ac4691

…/flutter#146720)

engine-flutter-autoroll mentioned this pull request Apr 24, 2024

Roll Flutter from 77043bae1a5e to dba4f7747441 (30 revisions) flutter/packages#6607

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2024

b0524b3 Add test for animated_positioned.0.dart API example. (flutter…

04609ca

…/flutter#146720)

HansMuller mentioned this pull request Apr 26, 2024

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

b0524b3 Add test for animated_positioned.0.dart API example. (flutter…

0ccc756

…/flutter#146720)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test for animated_positioned.0.dart API example. #146720

Add test for animated_positioned.0.dart API example. #146720

ksokolovskyi commented Apr 13, 2024

Renzo-Olivares left a comment

justinmc left a comment

ksokolovskyi commented Apr 20, 2024

Renzo-Olivares left a comment

ksokolovskyi commented Apr 23, 2024

Add test for animated_positioned.0.dart API example. #146720

Add test for animated_positioned.0.dart API example. #146720

Conversation

ksokolovskyi commented Apr 13, 2024

Description

Pre-launch Checklist

Renzo-Olivares left a comment

Choose a reason for hiding this comment

justinmc left a comment

Choose a reason for hiding this comment

ksokolovskyi commented Apr 20, 2024

Renzo-Olivares left a comment

Choose a reason for hiding this comment

ksokolovskyi commented Apr 23, 2024