[github actions] rewrite cherry pick template #144065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
friendly ping, would be great if I can get a review on this PR. Thank you! |
|
|
||
| **To fill in the form, you can edit this PR description and type your answers after the 'My Answer' keywords. <br> | ||
| A flutter domain expert will evaluate this cherry pick request shortly after ALL questions are answered.** | ||
| --- |
There was a problem hiding this comment.
We don't need dividers, when using an H2(##) dividers are built in.
However, we may want to remove them completely and change the headings to H3(###) to still provide visual space without adding clutter.
There was a problem hiding this comment.
Good point, changed to H3 and removed dividers
|
|
||
| - [ ] My answer: |
There was a problem hiding this comment.
Instead of using - [ ] My answer: would it be more readable to add generic text to be replaced? The template leaves me to assume that these are checklist items which confuse me as a user.
There was a problem hiding this comment.
Sure, replaced with texts placeholders
XilaiZhang
force-pushed
the
xilaizhang-template-1
branch
from
45b954b
to
98359d2
Compare
|
Thanks for the suggestions! The updated template will look something like this now |
|
friendly ping, would be great if I can get another review on this PR. Thank you! |
|
Impact_description has an underscore, it’s inconsistent with the rest of the headings, otherwise LGTM. |
itsjustkevin
approved these changes
Mar 1, 2024
|
|
||
| </pre> | ||
| ### impact_description: |
There was a problem hiding this comment.
Match this to the other headings.
There was a problem hiding this comment.
Good point! updated
XilaiZhang
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 2, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 2, 2024
flutter/flutter@ba719bc...65cd84b 2024-03-02 [email protected] Roll Flutter Engine from 8ef8543d6001 to 2706c732b22a (1 revision) (flutter/flutter#144493) 2024-03-02 [email protected] [github actions] rewrite cherry pick template (flutter/flutter#144065) 2024-03-01 [email protected] Roll Flutter Engine from 2a5a9a6dead0 to 8ef8543d6001 (1 revision) (flutter/flutter#144480) 2024-03-01 [email protected] Roll Packages from 6d02f03 to a9c68b8 (5 revisions) (flutter/flutter#144477) 2024-03-01 [email protected] Fix `showDateRangePicker` is missing `dartpad` tag and cleanup (flutter/flutter#144475) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/packages
that referenced
this pull request
Mar 7, 2024
flutter/flutter@ba719bc...65cd84b 2024-03-02 [email protected] Roll Flutter Engine from 8ef8543d6001 to 2706c732b22a (1 revision) (flutter/flutter#144493) 2024-03-02 [email protected] [github actions] rewrite cherry pick template (flutter/flutter#144065) 2024-03-01 [email protected] Roll Flutter Engine from 2a5a9a6dead0 to 8ef8543d6001 (1 revision) (flutter/flutter#144480) 2024-03-01 [email protected] Roll Packages from 6d02f03 to a9c68b8 (5 revisions) (flutter/flutter#144477) 2024-03-01 [email protected] Fix `showDateRangePicker` is missing `dartpad` tag and cleanup (flutter/flutter#144475) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
flutter/flutter@ba719bc...65cd84b 2024-03-02 [email protected] Roll Flutter Engine from 8ef8543d6001 to 2706c732b22a (1 revision) (flutter/flutter#144493) 2024-03-02 [email protected] [github actions] rewrite cherry pick template (flutter/flutter#144065) 2024-03-01 [email protected] Roll Flutter Engine from 2a5a9a6dead0 to 8ef8543d6001 (1 revision) (flutter/flutter#144480) 2024-03-01 [email protected] Roll Packages from 6d02f03 to a9c68b8 (5 revisions) (flutter/flutter#144477) 2024-03-01 [email protected] Fix `showDateRangePicker` is missing `dartpad` tag and cleanup (flutter/flutter#144475) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: @godofredoc pointed out that the fields in the PR template could be simplified and redesigned. Synced with @itsjustkevin and Kevin come up with changes in this doc which would improve the cherry pick template.
Github only supports a limited number of formatting options. This PR uses some workarounds and makes the following changes:
An example cherry pick template would look like this after the change.