continue->next in Ruby script #104296
Merged
continue->next in Ruby script #104296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
the
tool
|
looking now... |
| @@ -47,6 +71,7 @@ void main() { | |||
| }); | |||
|
|
|||
| tearDownAll(() { | |||
| hiddenFile.deleteSync(); | |||
There was a problem hiding this comment.
do we need to gracefully handle a failure here, or is that not an issue on mac?
There was a problem hiding this comment.
I'll swap to tryToDelete to match the next line.
christopherfujino
approved these changes
May 23, 2022
jmagman
commented
May 24, 2022
| @@ -2,8 +2,6 @@ | |||
| // Use of this source code is governed by a BSD-style license that can be | |||
| // found in the LICENSE file. | |||
|
|
|||
| // @dart = 2.8 | |||
There was a problem hiding this comment.
Also realized I could migrate this file.
jmagman
commented
May 24, 2022
| @@ -18,19 +18,19 @@ import 'package:test_api/test_api.dart' hide test; // ignore: deprecated_member_ | |||
|
|
|||
| export 'package:test_api/test_api.dart' hide test, isInstanceOf; // ignore: deprecated_member_use | |||
|
|
|||
| void tryToDelete(Directory directory) { | |||
| void tryToDelete(FileSystemEntity fileEntity) { | |||
There was a problem hiding this comment.
Can now take either File or Directory
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 24, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104118
The test change definitely failed on master without the Ruby fix, I double checked this time. 🙂
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.